Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing data in hmi tables #1432

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Aug 30, 2022

Pull Request Template

Issue Overview

This PR addresses #1431

  • This change addresses the issue in full

Description

On production currently, AMI %s and levels are not displaying on listings. The issue was in how we are passing cell data to tables.

How Can This Be Tested/Reviewed?

Checkout a listing on dev that has AMI levels (example)
And the same listing on this deploy preview (example)

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit 2a19db0
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/630e22ce411d490009c49c3d
😎 Deploy Preview https://deploy-preview-1432--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit 2a19db0
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/630e22cec936860008b71108
😎 Deploy Preview https://deploy-preview-1432--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for detroit-storybook-dev ready!

Name Link
🔨 Latest commit 2a19db0
🔍 Latest deploy log https://app.netlify.com/sites/detroit-storybook-dev/deploys/630e22ce84d69c000934e12c
😎 Deploy Preview https://deploy-preview-1432--detroit-storybook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥇

@emilyjablonski emilyjablonski merged commit 90c4dcd into dev Sep 1, 2022
@emilyjablonski emilyjablonski deleted the 1431/hmi-table-missing-data branch September 1, 2022 16:11
seanmalbert added a commit that referenced this pull request Sep 1, 2022
seanmalbert added a commit that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants