Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update bull version #1620

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: update bull version #1620

merged 1 commit into from
May 2, 2023

Conversation

ludtkemorgan
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses bloom-housing#3317

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Locally the backend runs and can be built. However, due to the way Heroku instances are deployed there is a dependency mismatch on the bull dependency (this is something only used by Detroit and not core). This PR upgrades @nestjs/bull to resolve that error. Error for reference: https://dashboard.heroku.com/apps/bloom-detroit/activity/builds/a1520773-4078-4ca2-8c3a-d63faeef8ba9

Reason for the error:

  • locally when installing the yarn packages it uses the yarn.lock file at the root of the directory. This tells yarn exactly which version of everything to download and install.
  • When deploying to Heroku it does not know about the yarn.lock file since it only knows about the backend/core directory (which has an empty yarn.lock file). So instead it has to install the packages based on package.json. Since there is a newer version of bull being downloaded that doesn't meet @nestjs/bull peer dependency ("^3.3 || ^3.22.0") it fails the install.

Reason this fixes it:

  • The upgraded version of @nestjs/bull has a peer dependency of bull versions "^3.3 || ^4.0.0" which our version of bull meets.
  • Luckily this doesn't appear to break any of the functionality of where bull is being used as far as I can tell.

How Can This Be Tested/Reviewed?

This was tested by going to backend/core and doing yarn build.

It has also been deployed to our dev site successfully: https://dashboard.heroku.com/apps/bloom-detroit/activity/builds/9c9710eb-3a21-4674-8cae-494bb62c8296

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Apr 21, 2023 •
edited
Loading

✅ Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit f24bdf6
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/6446caa7af20de0008206f9c
😎 Deploy Preview https://deploy-preview-1620--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 21, 2023 •
edited
Loading

✅ Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit f24bdf6
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/6446caa7047e5b00086c6705
😎 Deploy Preview https://deploy-preview-1620--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

YazeedLoonat
YazeedLoonat approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludtkemorgan ludtkemorgan merged commit 0b1a0fd into dev May 2, 2023
@ludtkemorgan ludtkemorgan deleted the 3317/bull branch May 2, 2023 18:17
ludtkemorgan added a commit that referenced this pull request Jul 24, 2023
@ludtkemorgan
fix: update bull version (#1620)
c5e5e53
@ludtkemorgan ludtkemorgan mentioned this pull request Jul 24, 2023
Merged
ludtkemorgan added a commit that referenced this pull request Jul 26, 2023
@ludtkemorgan @KrissDrawing @emilyjablonski
release: 2024-07-24 (#1630)
8926e09 
* feat: update major dependencies (#1589)

* fix: update bull version (#1620)

* 1577/download button can show and be non functional (#1621)

* fix: display paper application button download when application is present

* fix: hide redundant sections when data not provided

* refactor: use paperMethod prop to decide if display download button

* feat: uptake uic components (#1586)

* fix: change reset to setValue for disableUnitsAccordion (#1628)

* fix: various arabic layout fixes (#1629)

* fix: run correct node version

* fix: remove missed detroit-ui-components

* fix: prettier fixes

---------

Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyjablonski emilyjablonski emilyjablonski approved these changes

@YazeedLoonat YazeedLoonat YazeedLoonat approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludtkemorgan @YazeedLoonat @emilyjablonski