Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(home): transaction order bugfix #166

Merged
merged 5 commits into from
Oct 26, 2018
Merged

Chore(home): transaction order bugfix #166

merged 5 commits into from
Oct 26, 2018

Conversation

uvmetal
Copy link

@uvmetal uvmetal commented Oct 22, 2018

This fixes the following: Transaction Ordering #154

@uvmetal uvmetal changed the title Chore(home): transaction order bugfix for issue #154 Chore(home): transaction order bugfix Oct 22, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.428% when pulling 6a2a199 on phetter:chore(home) into d798c70 on CityOfZion:development.

DalderupMaurice
DalderupMaurice reviewed Oct 23, 2018
View reviewed changes
src/app/containers/Home/Home.js Outdated
txDetail.stringRemarks = []

txDetail.attributes.map((remark, i) => {
Neoscan.getAddressAbstracts(account.address, page).then(results => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole block is duplicate code, might by worth optimizing this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what do you mean? The getAddressAbstracts() call retrieves the summary pager data.

DalderupMaurice
DalderupMaurice reviewed Oct 23, 2018
View reviewed changes
Copy link

@DalderupMaurice DalderupMaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments above

@uvmetal uvmetal mentioned this pull request Oct 24, 2018
Closed
@DalderupMaurice
Copy link

could you remove the __tests__/components/__snapshots__/NetworkSwitcher.test.js.snap
I think this breaks the tests?

@DalderupMaurice
Copy link 

 FAIL  __tests__/components/NetworkSwitcher.test.js
  ● Test suite failed to run

    RangeError: Maximum call stack size exceeded
        at RegExp.[Symbol.match] (<anonymous>)
        at String.match (native)

      at exports.separateMessageFromStack.content (node_modules/jest-message-util/build/index.js:368:32)
          at Array.map (<anonymous>)

  console.log src/app/utils/api/neoscan.js:240
    neoscan.get_address_abstracts(): TypeError: Cannot read property 'URL' of null

  console.log src/app/utils/api/neoscan.js:240
    neoscan.get_address_abstracts(): TypeError: Cannot read property 'URL' of null

@uvmetal uvmetal merged commit 485b5e6 into CityOfZion:development Oct 26, 2018
@uvmetal
Copy link
Author

uvmetal commented Oct 26, 2018

All tests cleared locally. Merging per discussion with @DalderupMaurice

@DalderupMaurice
Copy link

I'll do a follow up PR for this very soon. Merged to unblock @phetter on the progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DalderupMaurice DalderupMaurice DalderupMaurice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uvmetal @coveralls @DalderupMaurice