This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Support RPC and REST in parallel #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2018 23:21
* Changed the initialization back so that both RPC and REST endpoints are supported in parallel once again.
|
do you happen to remember why we moved away from that approach in the first place? |
metachris
approved these changes
May 17, 2018
|
Iirc Tom thought we wouldn't run them in parallel anyway, and we've recently revisited this in #neopython |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
RPC and REST endpoints weren't supported in parallel.
How did you solve this problem?
Changed it back to the previous implementation so they can both run in parallel.
How did you make sure your solution works?
Tested it.
Are there any special changes in the code that we should be aware of?
No.
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)