Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Speedup np-import when appending blocks #962

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Speedup np-import when appending blocks #962

merged 2 commits into from
Jun 11, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jun 10, 2019

What current issue(s) does this address, or what feature is it adding?
when we supplied the -a flag for appending blocks, the code would still deserialise all data

How did you solve this problem?
skip block deserialization and move the file pointer directly to the next block until we've reached the current height

How did you make sure your solution works?
manual testing

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

coveralls commented Jun 10, 2019

Coverage Status

Coverage remained the same at 85.113% when pulling ab72804 on ixje:speedup-import into 82594df on CityOfZion:development.

@ixje ixje merged commit 82fdbc5 into CityOfZion:development Jun 11, 2019
@ixje ixje deleted the speedup-import branch June 11, 2019 06:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants