Implement SimplePolicyPlugin in Transaction.Verify #964

jseagrave21 · 2019-06-10T23:25:40Z

What current issue(s) does this address, or what feature is it adding?

addresses Simple Policy Plugin #960
- implements SimplePolicyPlugin when verifying a tx in the mempool

How did you solve this problem?
referenced logic used in #869 and logic I am using here https://github.com/jseagrave21/neo-python/blob/f75cb5dc58bedbfc12ea1a6afbca5332088f8ca6/neo/Core/TX/RawTransaction.py#L525-L541

How did you make sure your solution works?
make test and verification manually on my testnet node

Are there any special changes in the code that we should be aware of?
no

Please check the following, if applicable:

Did you add any tests?
Did you run make lint?
Did you run make test?
Are you making a PR to a feature branch or development rather than master?
Did you add an entry to CHANGELOG.rst? (if not, please do)

Merge CoZ Development into jseagrave21 Development

@localhuman

* Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods

…s thrown. (CityOfZion#663)

…yOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package

for compatibility

@localhuman

* Fix ExtendedJsonRpcApi (CityOfZion#662) * Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods * Mute expected test stacktrace and clearly identify why an exception is thrown. (CityOfZion#663) * Add guideline for adding tests to the neo-privnet-unittest image (CityOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package * Add raw transaction building examples (CityOfZion#665) * Update neo-boa version to fix core building test

Merge CoZ Development into jseagrave21 Development

Merge CoZ Development into jseagrave21 development

Merge CoZ development into jseagrave21 development

- add tests for "showallaccounts" and "showallaccountstates"

- revert

Merge neo-python development into jseagrave21 development

Merge CoZ development into jseagrave21 development

Gracefully handle NEP-5 balance query failures (CityOfZion#744)

Merge CoZ development into neo-python development

Merge CoZ development into jseagrave21 development

Merge CoZ Development into jseagrave21 development

Merge CoZ/neo-python development into jseagrave21/neo-python development

…into development

coveralls · 2019-06-10T23:30:27Z

Coverage increased (+0.04%) to 85.151% when pulling bde2df9 on jseagrave21:fix-tx-verify into 737477a on CityOfZion:development.

ixje

The solution does not seem to take the following rule into account (ref):

Deploy and invoke smart contract with neo-cli v2.10.2 will cost 0.001 GAS as the starting fee.

jseagrave21 · 2019-06-11T09:58:53Z

The solution does not seem to take the following rule into account (ref):

Deploy and invoke smart contract with neo-cli v2.10.2 will cost 0.001 GAS as the starting fee.

This was clarified in #dev-general on Discord by @vncoelho that this was only introduced in neo-cli and not a limitation on Seed Nodes or Concensus Nodes. It was discussed further and removed here: neo-project/neo-node#378

…into fix-tx-verify

ixje · 2019-06-11T12:03:29Z

I missed that. Thanks for the link!
Looks good then 👍 👍

vncoelho · 2019-06-11T12:06:40Z

The implementation looks precise and the formula correct.

ixje · 2019-06-11T12:09:48Z

thanks for the extra check @vncoelho

vncoelho

Maybe that if should be merged in the neocli as well.

vncoelho · 2019-06-11T12:10:48Z

neo/Core/TX/Transaction.py

+        fee = self.NetworkFee()
+        if self.Size() > settings.MAX_FREE_TX_SIZE and not self.Type == b'\x02':  # Claim Transactions are High Priority
+            req_fee = Fixed8.FromDecimal(settings.FEE_PER_EXTRA_BYTE * (self.Size() - settings.MAX_FREE_TX_SIZE))
+            if req_fee < settings.LOW_PRIORITY_THRESHOLD:


This was the trick point. Nice job!

ixje · 2019-06-12T13:12:00Z

100 points

lllwvlvwlll · 2019-07-18T16:51:45Z

https://neoscan.io/transaction/fac61168bee1eeffbc96ad2ac83e0e9d5fbb74c5c22a72e3bbf837bcea12cfbb

jseagrave21 and others added 30 commits October 9, 2018 20:38

Merge pull request #38 from CityOfZion/development

13e979b

Merge CoZ Development into jseagrave21 Development

Merge pull request #40 from CityOfZion/development

e41e950

Merge CoZ Development into jseagrave21 Development

Merge pull request #41 from CityOfZion/development

7db54f4

Merge CoZ Development into jseagrave21 Development

Fix ExtendedJsonRpcApi (CityOfZion#662)

54a4f3f

* Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods

Mute expected test stacktrace and clearly identify why an exception i…

0f96dc3

…s thrown. (CityOfZion#663)

Add guideline for adding tests to the neo-privnet-unittest image (Cit…

1e5b4dc

…yOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package

Update CHANGELOG.rst

8febcf1

for compatibility

Update CHANGELOG.rst

c7a790f

Merge pull request #50 from CityOfZion/development

32a16e3

Merge CoZ Development into jseagrave21 Development

Merge pull request #53 from CityOfZion/development

3c8232d

Merge CoZ Development into jseagrave21 Development

Merge pull request #54 from CityOfZion/development

1b00db8

Merge CoZ Development into jseagrave21 Development

Merge pull request #58 from CityOfZion/development

eb495bf

Merge CoZ Development into jseagrave21 development

Merge pull request #63 from CityOfZion/development

4df642e

Merge CoZ development into jseagrave21 development

Update test_extended_json_rpc_api.py

e12e746

- add tests for "showallaccounts" and "showallaccountstates"

Update test_extended_json_rpc_api.py

0f55903

- revert

Merge pull request #64 from CityOfZion/development

7eb4a1e

Merge neo-python development into jseagrave21 development

Merge pull request #66 from CityOfZion/development

1f40685

Merge neo-python development into jseagrave21 development

Merge pull request #74 from CityOfZion/development

16f5163

Merge neo-python development into jseagrave21 development

Merge pull request #81 from CityOfZion/development

ff49beb

Merge CoZ development into jseagrave21 development

Merge pull request #82 from CityOfZion/development

05ce2e7

Gracefully handle NEP-5 balance query failures (CityOfZion#744)

Merge pull request #92 from CityOfZion/development

19dce4f

Merge CoZ development into neo-python development

Merge pull request #95 from CityOfZion/development

08cd57f

Merge CoZ development into jseagrave21 development

Merge pull request #97 from CityOfZion/development

e085410

Merge CoZ Development into jseagrave21 development

Merge pull request #102 from CityOfZion/development

84c8478

Merge CoZ/neo-python development into jseagrave21/neo-python development

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

1415597

…into development

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

d07a330

…into development

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

f2f64a1

…into development

implement SimplePolicyPlugin in Transaction.Verify

8638bc1

update CHANGELOG.rst

353eab9

ixje suggested changes Jun 11, 2019

View reviewed changes

jseagrave21 and others added 2 commits June 11, 2019 06:06

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

4a2aad7

…into fix-tx-verify

Merge branch 'development' into fix-tx-verify

bde2df9

ixje merged commit 7e29227 into CityOfZion:development Jun 11, 2019

vncoelho reviewed Jun 11, 2019

View reviewed changes

jseagrave21 deleted the fix-tx-verify branch June 11, 2019 14:57

hal0x2328 mentioned this pull request Jul 17, 2019

Simple Policy Plugin #960

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement SimplePolicyPlugin in Transaction.Verify #964

Implement SimplePolicyPlugin in Transaction.Verify #964

jseagrave21 commented Jun 10, 2019 •

edited

Loading

coveralls commented Jun 10, 2019 •

edited

Loading

ixje left a comment

jseagrave21 commented Jun 11, 2019

ixje commented Jun 11, 2019

vncoelho commented Jun 11, 2019

ixje commented Jun 11, 2019

vncoelho left a comment

vncoelho Jun 11, 2019

ixje commented Jun 12, 2019

lllwvlvwlll commented Jul 18, 2019 •

edited

Loading

Implement SimplePolicyPlugin in Transaction.Verify #964

Implement SimplePolicyPlugin in Transaction.Verify #964

Conversation

jseagrave21 commented Jun 10, 2019 • edited Loading

coveralls commented Jun 10, 2019 • edited Loading

ixje left a comment

Choose a reason for hiding this comment

jseagrave21 commented Jun 11, 2019

ixje commented Jun 11, 2019

vncoelho commented Jun 11, 2019

ixje commented Jun 11, 2019

vncoelho left a comment

Choose a reason for hiding this comment

vncoelho Jun 11, 2019

Choose a reason for hiding this comment

ixje commented Jun 12, 2019

lllwvlvwlll commented Jul 18, 2019 • edited Loading

jseagrave21 commented Jun 10, 2019 •

edited

Loading

coveralls commented Jun 10, 2019 •

edited

Loading

lllwvlvwlll commented Jul 18, 2019 •

edited

Loading