Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent grass spread to reinforced dirt #351

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Prevent grass spread to reinforced dirt #351

merged 2 commits into from
Mar 19, 2024

Conversation

MrJeremyFisher
Copy link
Contributor

No description provided.

AngrySoundTech
AngrySoundTech approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@AngrySoundTech AngrySoundTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I assume reinforcement caching would make this not too intensive? Grass seems to try to spread more than any other of our checks here that we prevent.

If someone else thinks that's sane too then we should be good.

@MrJeremyFisher
Copy link
Contributor Author

Yeah, I tried some testing on a large area of grass & dirt and didn't see too much performance impact. Unsure how it would perform on live though obviously

@RedDevel2 RedDevel2 added this to the 1.27.0 milestone Mar 4, 2024
@okx-code okx-code modified the milestones: 1.27.0, 1.26.5 Mar 19, 2024
@okx-code okx-code merged commit a3e7a10 into CivMC:main Mar 19, 2024
2 checks passed
okx-code added a commit that referenced this pull request Nov 16, 2024
@okx-code
Merge pull request #351 from MrJeremyFisher/no-reinforced-grass-spread
d3f2a97 
Prevent grass spread to reinforced dirt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awoo-civ awoo-civ awoo-civ left review comments

@AngrySoundTech AngrySoundTech AngrySoundTech approved these changes

@okx-code okx-code okx-code approved these changes

Assignees

@MrJeremyFisher MrJeremyFisher

Labels
Category: Bug Priority: Low
Projects
CivMC Roadmap
Status: Done
Milestone
1.26.5
Development

Successfully merging this pull request may close these issues.
5 participants
@MrJeremyFisher @okx-code @awoo-civ @AngrySoundTech @RedDevel2