-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper /nldg confirmation #383
Conversation
...ins/namelayer-paper/src/main/java/vg/civcraft/mc/namelayer/command/commands/DeleteGroup.java
Outdated
Show resolved
Hide resolved
...ins/namelayer-paper/src/main/java/vg/civcraft/mc/namelayer/command/commands/DeleteGroup.java
Outdated
Show resolved
Hide resolved
...ins/namelayer-paper/src/main/java/vg/civcraft/mc/namelayer/command/commands/DeleteGroup.java
Outdated
Show resolved
Hide resolved
...ins/namelayer-paper/src/main/java/vg/civcraft/mc/namelayer/command/commands/DeleteGroup.java
Outdated
Show resolved
Hide resolved
You can use |
🎉 |
Could you do the confirmation without an underscore? |
Sure. I just wasn't sure whether the command uses greedy string or normal string arguments. I'll look into it |
@okx-code I removed underscores from the message but I'm not sure whether the command takes a normal string argument or a greedy string |
Have you tested it? |
Not yet, need to build the plugin |
@okx-code |
@drekamor Hmm, perhaps |
Was thinking about that as well. I'll add them |
Imo the message shouldn't mention snitches and bastions as Citadel doesn't need to be run with Bastion and Jukealert and it won't necessarily be on other servers. |
That's up to the admins I suppose, but personally I'm vehemently against supporting anything other than the needs of CivMC if it requires any sacrifices. |
People still delete group by accident because the command is similar to /nlsdg and the confirmation request is green (which implies safety of the operation)