Massively simplify BeeKeeping output #405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protonull
force-pushed
the
fix-beekeeping
branch
from
9f0c012
to
be5aa03
Compare
Protonull
force-pushed
the
fix-beekeeping
branch
from
be5aa03
to
937b70e
Compare
BeeKeeping no longer tells you the names of the bees in the hive. It's genuinely more hassle than it's worth to have it output properly. And while I was at it, I also fixed up the rest of the class.
Protonull
force-pushed
the
fix-beekeeping
branch
from
937b70e
to
46111b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeeKeeping will no longer tell you the names of the bees in the hive, if any. It's genuinely more hassle than it's worth to have it output properly. Here are some examples of botched outputs:
Trying to fix this, where named and unnamed bees are mentioned, involves massive if-else trees to accommodate proper Oxford commas and plurals, which makes the code pretty fragile. Showing bee names is neat but by no means a necessity.