Prune PDC package #555
Closed
Prune PDC package #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protonull
force-pushed
the
pdc-boolean
branch
3 times, most recently
from
ce82798
to
b0b49c9
Compare
It seems that PaperMC (or upstream) has finally added a premade boolean PDC type, so it's no longer necessary for us to have our own.
PaperMC (or upstream) has finally added a native way to handle lists in PDCs.
The only thing this has over native PDCs is the size() method, which is never used regardless, nor is the class itself outside of NBTSerialization.fromPDC(), which itself is never used.
This has gone entirely unused and would likely not play nicely with PDCs due to its non-specific Map.class complex type. Better to require users to create a PDT for a specific record class.
This has gone entirely unused, but is also becoming more and more risky as certain APIs are shifting away from enums. For example, there's an intention to move Material away from an enum. This would make this PDT fail outright, even if the enum methods (like values()) are polyfilled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that PaperMC (or upstream) has finally added a few things that the
pdcpackage gap-filled, so it's no longer necessary for us to have or maintain these custom solutions. I have also removed some things that aren't used.