Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on pr instead of creating new one #570

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Huskydog9988
Copy link
Contributor

Fixes issue of bot sending new comment instead of updating the existing one

@okx-code okx-code merged commit 86c292f into CivMC:main Oct 15, 2024
2 checks passed
okx-code added a commit that referenced this pull request Oct 15, 2024
okx-code added a commit that referenced this pull request Oct 15, 2024
Revert "Merge pull request #570 from Huskydog9988/fix-comment-on-pr"
@okx-code
Copy link
Contributor

@Huskydog9988 seems like this change is broken so I reverted https://github.com/CivMC/Civ/actions/runs/11354153170/job/31580752772

This issue looks related and might help to fix peter-evans/find-comment#172

@Huskydog9988
Copy link
Contributor Author

The issue is related to how the workflow gets the pr number from github actions. You can see the failure in the step before.

Previous Job ID: 11354132682
Previous Suite ID: 29662588586
Artifact ID: 
Pull request Number: null
Head SHA: null

I might be able to figure out a fix for this, but github actions is like black magic to me, so we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Release
Development

Successfully merging this pull request may close these issues.

3 participants