Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted XP recipes for RB changes #135

Merged
merged 2 commits into from
Aug 11, 2015
Merged

Adjusted XP recipes for RB changes #135

merged 2 commits into from
Aug 11, 2015

Conversation

Goldmattress
Copy link

Adjusted XP recipes for RB pull request #51 Civcraft/RealisticBiomes#51

Adjusted XP recipes for RB pull request #51 Civcraft/RealisticBiomes#51
@CivcraftBot
Copy link

Can one of the admins verify this patch? Type 'ok to test' to test.

1 similar comment
@CivcraftBot
Copy link

Can one of the admins verify this patch? Type 'ok to test' to test.

@ProgrammerDan
Copy link

yaml looks good

@ttk2
Copy link

ttk2 commented Aug 7, 2015

So does this just divide requirements by 12?

@benjajaja
Copy link

Yes

@Goldmattress
Copy link
Author

16
On 7 Aug 2015 23:06, "ttk2" notifications@github.com wrote:

So does this just divide requirements by 12?


Reply to this email directly or view it on GitHub
#135 (comment).

@DoctorCerebral
Copy link

Shouldn't the requirements be divided 24 since the growths times got multiplied by 24?

@ttk2
Copy link

ttk2 commented Aug 8, 2015

if yall thinks this is the right ratio get it on Civtest and get some testing done, we can roll it into production soon.

@ttk2
Copy link

ttk2 commented Aug 9, 2015

@Goldmattress so whats going on here? Should I just merge this and roll it online? Does it need testing?

@Goldmattress
Copy link
Author

It was not it's fixed now, all requirements are reduced by 16x and in the RB pull speed is reduced 24x
Given the greater potential for production with a single account now I believe this to be a balanced change.

And yes there is basically no point in testing, this is numbers change not any sort of recipe changes or rejigs.

@ProgrammerDan
Copy link

Agreed, I have no objections to immediate merge and deploy.

@ttk2
Copy link

ttk2 commented Aug 9, 2015

very well then, it can go online Tuesday when I can oversee it and do some community management for it.

@hlprimm
Copy link

hlprimm commented Aug 10, 2015

So is it better to just not make any XP until Tuesday?

@ttk2
Copy link

ttk2 commented Aug 10, 2015

well yes.

ttk2 added a commit that referenced this pull request Aug 11, 2015
Adjusted XP recipes for RB changes
@ttk2 ttk2 merged commit 9e41786 into Civcraft:master Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants