Breaking snitches now displays who owns them and what group they were on #50
Conversation
| @@ -301,6 +301,14 @@ public void breakSnitchBlock(BlockBreakEvent event) { | |||
| return; | |||
| } | |||
| Block block = event.getBlock(); | |||
| if(block.getType().equals(Material.JUKEBOX) || block.getType().equals(Material.NOTE_BLOCK) && plugin.getConfigManager().isDisplayOwnerOnBreak()) { | |||
There was a problem hiding this comment.
Dont think this logic is right. Shouldn't it be
if((block.getType().equals(Material.JUKEBOX) || block.getType().equals(Material.NOTE_BLOCK)) && plugin.getConfigManager().isDisplayOwnerOnBreak())
|
The logic should still work but i can add the extra parenthesis just to be sure. as for the config thing, those are definitely parenthesis... |
|
For the if statement lets say some breaks a Jukebox wouldnt and config was set to false: true || false && false == true || false making the statement true even though it should be false or am I messing up? |
|
ok to test |
1 similar comment
|
ok to test |
|
Can one of the admins verify this patch? Type 'ok to test' to test. |
|
ok to test |
Fixed potential logic issue
For some reason my macbook decided that quotes are not quotes and messed it up
|
Also I think you meant to say they weren't quotes not they weren't parenthesis |
|
Lol yep.
|
|
ok to test |
|
@rourke750 can we merge this? |
|
Did you test this? |
|
bump. On Mon, Dec 14, 2015 at 8:21 AM, Max Baumstark notifications@github.com
|
Before I derped and it was getting the world object, now it just gets the world name
|
yes |
Breaking snitches now displays who owns them and what group they were on
No description provided.