Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New commands #9

Closed
erocs opened this issue Sep 29, 2014 · 15 comments
Closed

New commands #9

erocs opened this issue Sep 29, 2014 · 15 comments
Assignees

Comments

@erocs
Copy link

erocs commented Sep 29, 2014

Please add /ppban and /ppunban to manage PP's ban list. Yes people could just become re-banned due to an alt list, but these will be useful at times.

Also a /ppgetalts to report PP's current view of a player or account's alt list.

@rourke750
Copy link

I was thinking of ppgetalts. Wouldn't that just pull from misc log if it wasn't dealing with the alts before though? I'm guessing just for sub admins.

@rourke750 rourke750 self-assigned this Sep 29, 2014
@erocs
Copy link
Author

erocs commented Sep 29, 2014

Just wanting a way to introspect what PP has cached from the alt plugin.
That way we could remove the accounts from the debug spew and not slow down
the server printing out huge lists.

On Mon, Sep 29, 2014 at 3:13 PM, rourke750 notifications@github.com wrote:

I was thinking of ppgetalts. Wouldn't that just pull from misc log if it
wasn't dealing with the alts before though? I'm guessing just for sub
admins.


Reply to this email directly or view it on GitHub
#9 (comment).

@rourke750
Copy link

I'm curious how you do it because with mine it was never slow. Is it just because there is so much more data with yours?

@erocs
Copy link
Author

erocs commented Sep 29, 2014

Printing out lists of 1200 players takes a while...

On Mon, Sep 29, 2014 at 3:17 PM, rourke750 notifications@github.com wrote:

I'm curious how you do it because with mine it was never slow. Is it just
because there is so much more data with yours?


Reply to this email directly or view it on GitHub
#9 (comment).

@rourke750
Copy link

1 player has over 1200 associations?

@erocs
Copy link
Author

erocs commented Sep 29, 2014

There isn't "1 player has x associations". There's at least one 1200 player
alt list.

On Mon, Sep 29, 2014 at 3:34 PM, rourke750 notifications@github.com wrote:

1 player has over 1200 associations?


Reply to this email directly or view it on GitHub
#9 (comment).

@rourke750
Copy link

How, how does that happen?

@erocs
Copy link
Author

erocs commented Sep 29, 2014

Doesn't matter. So yes, I was just wanting this command to dump out the
cached alt list for a given player. It shouldn't query for a new list if it
doesn't have one or to refresh the current one.

On Mon, Sep 29, 2014 at 3:36 PM, rourke750 notifications@github.com wrote:

How, how does that happen?


Reply to this email directly or view it on GitHub
#9 (comment).

@rourke750
Copy link

looks like ppgetalts was already there

@erocs
Copy link
Author

erocs commented Sep 29, 2014

Cool, did it pull from the old alts.txt or use the in-memory cache?

On Mon, Sep 29, 2014 at 3:47 PM, rourke750 notifications@github.com wrote:

looks like ppgetalts was already there


Reply to this email directly or view it on GitHub
#9 (comment).

@rourke750
Copy link

it used to pull but I added caching for something else.

@rourke750
Copy link

28d46c0

@erocs
Copy link
Author

erocs commented Sep 29, 2014

I wasn't thinking to ban / unban the entire alt list, but just individual
players. Hrm, let's work with this and see if it's enough. I can reopen
this later if we need individual ban/pardon.

On Mon, Sep 29, 2014 at 4:34 PM, rourke750 notifications@github.com wrote:

Closed #9 #9.


Reply to this email directly or view it on GitHub
#9 (comment).

@rourke750
Copy link

unbanning / banning individuals is a bit more work since as soon as they
were to log in they would just get rebanned here:
https://github.com/Civcraft/PrisonPearl/blob/master/src/com/untamedears/PrisonPearl/PrisonPearlPlugin.java#L449

On Mon, Sep 29, 2014 at 7:36 PM, erocs notifications@github.com wrote:

I wasn't thinking to ban / unban the entire alt list, but just individual
players. Hrm, let's work with this and see if it's enough. I can reopen
this later if we need individual ban/pardon.

On Mon, Sep 29, 2014 at 4:34 PM, rourke750 notifications@github.com
wrote:

Closed #9 #9.


Reply to this email directly or view it on GitHub
#9 (comment).


Reply to this email directly or view it on GitHub
#9 (comment).

@erocs
Copy link
Author

erocs commented Sep 29, 2014

Good point. Of course, unbanning the entire list will achieve the same
thing with their next login. This should be fine as it is only supposed to
be an emergency measure if we think they weren't properly banned or
unbanned via PP.

On Mon, Sep 29, 2014 at 4:38 PM, rourke750 notifications@github.com wrote:

unbanning / banning individuals is a bit more work since as soon as they
were to log in they would just get rebanned here:

https://github.com/Civcraft/PrisonPearl/blob/master/src/com/untamedears/PrisonPearl/PrisonPearlPlugin.java#L449

On Mon, Sep 29, 2014 at 7:36 PM, erocs notifications@github.com wrote:

I wasn't thinking to ban / unban the entire alt list, but just
individual
players. Hrm, let's work with this and see if it's enough. I can reopen
this later if we need individual ban/pardon.

On Mon, Sep 29, 2014 at 4:34 PM, rourke750 notifications@github.com
wrote:

Closed #9 #9.


Reply to this email directly or view it on GitHub
#9 (comment).


Reply to this email directly or view it on GitHub
#9 (comment).


Reply to this email directly or view it on GitHub
#9 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants