Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Loaded Pearls Being Free'd #17

Merged
merged 1 commit into from
Nov 20, 2014
Merged

Conversation

Ty4Code
Copy link

@Ty4Code Ty4Code commented Nov 19, 2014

Fixes issue #15. Prevents previously unloaded pearls
from being free'd/expired even if the chunk has been reloaded.

Fixes issue Civcraft#15. Prevents previously unloaded pearls
from being free'd/expired even if the chunk has been reloaded.
@ttk2
Copy link

ttk2 commented Nov 19, 2014

what exactly was the issue?

On Wed, Nov 19, 2014 at 4:04 PM, MrTwiggy notifications@github.com wrote:

Fixes issue #15
#15. Prevents previously
unloaded pearls

from being free'd/expired even if the chunk has been reloaded.

You can merge this Pull Request by running

git pull https://github.com/MrTwiggy/PrisonPearl master

Or view, comment on, or merge it at:

#17
Commit Summary

  • Prevent Loaded Pearls Being Free'd

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#17.

@Ty4Code
Copy link
Author

Ty4Code commented Nov 19, 2014

The issue was that if a prison pearl was dropped on the ground, and then the chunk that the pearl was inside was unloaded. The pearl was added to a list, and after a certain delay, the pearl was "free'd" and destroyed, regardless of whether the chunk was re-loaded again.

@ttk2
Copy link

ttk2 commented Nov 20, 2014

ah, so this just cancels the event on reload. Strange I remember a pull to
fix that earlier.

On Wed, Nov 19, 2014 at 4:11 PM, MrTwiggy notifications@github.com wrote:

The issue was that if a prison pearl was dropped on the ground, and then
the chunk that the pearl was inside was unloaded. The pearl was added to a
list, and after a certain delay, the pearl was "free'd" and destroyed,
regardless of whether the chunk was re-loaded again.


Reply to this email directly or view it on GitHub
#17 (comment).

@rourke750
Copy link

@ttk2 Its a little different. Anyways code is good so I'm merging. Check for a new jar on jenkins and this can go live without testing.

rourke750 added a commit that referenced this pull request Nov 20, 2014
Prevent Loaded Pearls Being Free'd
@rourke750 rourke750 merged commit 4b49670 into Civcraft:master Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants