Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cactus grows without sunlight #38

Closed
Goldmattress opened this issue Jul 16, 2015 · 7 comments
Closed

Cactus grows without sunlight #38

Goldmattress opened this issue Jul 16, 2015 · 7 comments

Comments

@Goldmattress
Copy link

Cactus grows without sunlight, even if there is a block above it, it will still grow.

@benjajaja
Copy link

That's vanilla. RB penalizes the lack of sunlight but it still grows.

@Goldmattress
Copy link
Author

No its not look at the config, it inherits column which requires sunlight,
this is a bug.
On 16 Jul 2015 07:51, "Benjamin Grosse" notifications@github.com wrote:

That's vanilla. RB penalizes the lack of sunlight but it still grows.


Reply to this email directly or view it on GitHub
#38 (comment)
.

@benjajaja
Copy link

"requires sunlight" means that a penalty is applied, not that it does not grow at all. Cactus also used to grow on civcraft before the update to persistence, just slower. I have a farm with the cacti in columns without direct sunlight, I have seen it work.

@Goldmattress
Copy link
Author

That is absolutely not how it was supposed to work, every bit of documentation has indicated that all columnar plants require sunlight or glow stone to grow. I know very well that it has worked for a long time I just didn't bother to post about it till now.

@benjajaja
Copy link

See here how it was always a penalty. Before that commit I think there was a "openSkyBonus" modifier. So I don't know where you got that it absolutely requires full sunlight to grow.

Here is a screenshot of a vertical cactus farm that is over a year old:

I remember that the builder did the math for not-full-sunlight and space efficiency.

@ProgrammerDan
Copy link

Given the long history, changing this would be an absolutely enormous nerf,
perhaps two orders of magnitudes for a larger stacked farm.

I'm not in favor of this change, for now, instead we should fix the docs to
reflect actual behavior.
On Jul 17, 2015 8:08 PM, "Benjamin Grosse" notifications@github.com wrote:

See here
https://github.com/Civcraft/RealisticBiomes/blame/master/src/com/untamedears/realisticbiomes/GrowthConfig.java#L298
how it was always a penalty. Before that commit I think there was a
"openSkyBonus" modifier. So I don't know where you got that it absolutely
requires full sunlight to grow.

Here is a screenshot of a vertical cactus farm that is over a year old:

https://camo.githubusercontent.com/d371d516e5ea3caa51a9d0936c94d13762b7f44f/687474703a2f2f692e696d6775722e636f6d2f7a7a644c57654e2e6a70673f31
I remember that the builder did the math for not-full-sunlight and space
efficiency.


Reply to this email directly or view it on GitHub
#38 (comment)
.

@benjajaja
Copy link

Ok closing, in the wiki article I wrote it is clear that lack of sunlight only applies a penalty https://github.com/Civcraft/RealisticBiomes/wiki#light-bonus

psygate pushed a commit to psygate/RealisticBiomes that referenced this issue Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants