Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reloading of config only done if default created. #18

Merged
merged 1 commit into from
May 31, 2015

Conversation

plebes
Copy link

@plebes plebes commented May 30, 2015

Problem: The configuration file was being "reloaded" from file regardless of the creation or non-creation of a default configuration. (Loaded twice when the file was fine.)

Fix: The reloading is done only if a default configuration had to be created into the data directory due to a missing or corrupted configuration (command was moved inside the conditional block).

@ttk2
Copy link

ttk2 commented May 30, 2015

looks like a good fix, I will let one of the dev guys merge it, thanks for
getting simple things like this! Hopefully it saves us some trouble down
the road.

On Fri, May 29, 2015 at 10:37 PM plebes notifications@github.com wrote:

Problem: The configuration file was being "reloaded" from file
regardless of the creation or non-creation of a default configuration.
(Loaded twice when the file was fine.)

Fix: The reloading is done only if a default configuration had to be
created into the data directory due to a missing or corrupted configuration

(command was moved inside the conditional block).

You can view, comment on, or merge this pull request online at:

#18
Commit Summary

  • Fix: Reloading of config only done if default created.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#18.

ttk2 added a commit that referenced this pull request May 31, 2015
Fix: Reloading of config only done if default created.
@ttk2 ttk2 merged commit 2c9f2c6 into Civcraft:master May 31, 2015
@ttk2
Copy link

ttk2 commented May 31, 2015

merged testing tomorrow.

psygate pushed a commit to psygate/RealisticBiomes that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants