Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with variants #5

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Fix bugs with variants #5

merged 2 commits into from
Oct 30, 2022

Conversation

toolcreator
Copy link
Contributor

So apparently the #2 wasn't 100% ready for merge yet...

There was a broken regex in the simpleyaml library, and the CMakeSelectBuildType command would fail when trying to remove a non-existend build directory.

@Civitasv
Copy link
Owner

Oops, my fault, I'll check it seriously tomorrow.

@Civitasv Civitasv merged commit 2cad3e8 into Civitasv:master Oct 30, 2022
@Civitasv
Copy link
Owner

Still have problems in my computer.
Keep notifying can't open file.

@Civitasv
Copy link
Owner

Civitasv commented Oct 30, 2022

I've made all changes to new branch cmake-variants, and revert master. Tomorrow I'll debug it.

Civitasv added a commit that referenced this pull request Jan 7, 2023
Civitasv added a commit that referenced this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants