Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined reference to __aeabi_uldivmod in drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko #1012

Closed
nickdesaulniers opened this issue Apr 28, 2020 · 3 comments
Closed

undefined reference to __aeabi_uldivmod in drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko #1012

nickdesaulniers opened this issue Apr 28, 2020 · 3 comments
Assignees
@nathanchance
Labels
[ARCH] arm32 This bug impacts ARCH=arm [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle [Reported-by] KernelCI Reported-by: kernelci.org bot <bot@kernelci.org>

Comments

@nickdesaulniers
Copy link
Member

arm32 allmodconfig linux-next reported by kernelci

    ERROR: modpost: "__aeabi_uldivmod" [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!

typically means that a helper function needs to be called rather than use the division operator for 64b inputs.
@nickdesaulniers nickdesaulniers added good first issue Good for newcomers [ARCH] arm32 This bug impacts ARCH=arm [BUG] linux-next This is an issue only seen in linux-next [Reported-by] KernelCI Reported-by: kernelci.org bot <bot@kernelci.org> labels Apr 28, 2020
@nathanchance
Copy link
Member

Patch sent: https://lore.kernel.org/lkml/20200428174221.2040849-1-natechancellor@gmail.com/

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed good first issue Good for newcomers labels Apr 28, 2020
@nathanchance nathanchance self-assigned this Apr 28, 2020
@nickdesaulniers nickdesaulniers added [PATCH] Submitted A patch has been submitted for review and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Apr 28, 2020
fengguang pushed a commit to 0day-ci/linux that referenced this issue Apr 28, 2020
@nathanchance @intel-lab-lkp
dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show
621058e 
When building arm32 allmodconfig:

ERROR: modpost: "__aeabi_uldivmod"
[drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!

frames and cdan are both of type __u64 (unsigned long long) so we need
to use div64_u64 to avoid this issues.

Fixes: 460fd83 ("dpaa2-eth: add channel stat to debugfs")
Link: ClangBuiltLinux#1012
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
@nathanchance
Copy link
Member

Patch accepted: https://git.kernel.org/netdev/net-next/c/88fb831f773e6c51ec528eacb524f00f518f7e54

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Apr 28, 2020
@nathanchance
Copy link
Member

Fixed in -next: https://git.kernel.org/next/linux-next/c/88fb831f773e6c51ec528eacb524f00f518f7e54

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
[ARCH] arm32 This bug impacts ARCH=arm [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle [Reported-by] KernelCI Reported-by: kernelci.org bot <bot@kernelci.org>
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickdesaulniers @nathanchance