Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Winteger-overflow in drivers/gpu/drm/amd/amdgpu/amdgpu_device.c #1017

Closed
nathanchance opened this issue May 2, 2020 · 3 comments
Closed

-Winteger-overflow in drivers/gpu/drm/amd/amdgpu/amdgpu_device.c #1017

nathanchance opened this issue May 2, 2020 · 3 comments
Assignees
@nathanchance
Labels
-Winteger-overflow [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4160:53: warning: overflow in expression; result is -294967296 with type 'long' [-Winteger-overflow]
                expires = ktime_get_mono_fast_ns() + NSEC_PER_SEC * 4L;
                                                                  ^
1 warning generated.

Patch submitted: https://lore.kernel.org/lkml/20200502031141.2732221-1-natechancellor@gmail.com/
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next -Winteger-overflow labels May 2, 2020
@nathanchance nathanchance self-assigned this May 2, 2020
fengguang pushed a commit to 0day-ci/linux that referenced this issue May 2, 2020
@nathanchance @intel-lab-lkp
drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_a…
a315ce8 
…udio

When building with Clang:

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4160:53: warning: overflow in
expression; result is -294967296 with type 'long' [-Winteger-overflow]
                expires = ktime_get_mono_fast_ns() + NSEC_PER_SEC * 4L;
                                                                  ^
1 warning generated.

Multiplication happens first due to order of operations and both
NSEC_PER_SEC and 4 are long literals so the expression overflows. To
avoid this, make 4 an unsigned long long literal, which matches the
type of expires (u64).

Fixes: 3f12acc ("drm/amdgpu: put the audio codec into suspend state before gpu reset V3")
Link: ClangBuiltLinux#1017
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
@nickdesaulniers nickdesaulniers added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels May 5, 2020
@nickdesaulniers
Copy link
Member

@arndb sent a patch for this too, shortly after you did.

@nathanchance
Copy link
Member Author

Patch accepted: https://cgit.freedesktop.org/~agd5f/linux/commit/?id=ee94b6c318d6518092617800a27e7481390bed82

ruscur pushed a commit to ruscur/linux that referenced this issue May 7, 2020
@nathanchance @alexdeucher
drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_a…
54b7feb 
…udio

When building with Clang:

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4160:53: warning: overflow in
expression; result is -294967296 with type 'long' [-Winteger-overflow]
                expires = ktime_get_mono_fast_ns() + NSEC_PER_SEC * 4L;
                                                                  ^
1 warning generated.

Multiplication happens first due to order of operations and both
NSEC_PER_SEC and 4 are long literals so the expression overflows. To
avoid this, make 4 an unsigned long long literal, which matches the
type of expires (u64).

Fixes: 3f12acc ("drm/amdgpu: put the audio codec into suspend state before gpu reset V3")
Link: ClangBuiltLinux#1017
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
@nathanchance
Copy link
Member Author

https://git.kernel.org/next/linux-next/c/54b7feb93fc33c48619472d8b7fce41cc5acafc9

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels May 7, 2020
kentrussell pushed a commit to ROCm/ROCK-Kernel-Driver that referenced this issue Jul 8, 2020
@nathanchance
drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_a…
1f930f9 
…udio

When building with Clang:

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4160:53: warning: overflow in
expression; result is -294967296 with type 'long' [-Winteger-overflow]
                expires = ktime_get_mono_fast_ns() + NSEC_PER_SEC * 4L;
                                                                  ^
1 warning generated.

Multiplication happens first due to order of operations and both
NSEC_PER_SEC and 4 are long literals so the expression overflows. To
avoid this, make 4 an unsigned long long literal, which matches the
type of expires (u64).

Fixes: 3f12acc ("drm/amdgpu: put the audio codec into suspend state before gpu reset V3")
Link: ClangBuiltLinux/linux#1017
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
maurossi pushed a commit to maurossi/linux that referenced this issue Jul 16, 2020
@nathanchance @amdgerritcr
drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_a…
ee94b6c 
…udio

When building with Clang:

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4160:53: warning: overflow in
expression; result is -294967296 with type 'long' [-Winteger-overflow]
                expires = ktime_get_mono_fast_ns() + NSEC_PER_SEC * 4L;
                                                                  ^
1 warning generated.

Multiplication happens first due to order of operations and both
NSEC_PER_SEC and 4 are long literals so the expression overflows. To
avoid this, make 4 an unsigned long long literal, which matches the
type of expires (u64).

Fixes: 3f12acc ("drm/amdgpu: put the audio codec into suspend state before gpu reset V3")
Link: ClangBuiltLinux/linux#1017
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
wulf7 pushed a commit to freebsd/drm-kmod that referenced this issue Feb 20, 2022
@nathanchance @wulf7
drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_a…
8b7a829 
…udio

When building with Clang:

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4160:53: warning: overflow in
expression; result is -294967296 with type 'long' [-Winteger-overflow]
                expires = ktime_get_mono_fast_ns() + NSEC_PER_SEC * 4L;
                                                                  ^
1 warning generated.

Multiplication happens first due to order of operations and both
NSEC_PER_SEC and 4 are long literals so the expression overflows. To
avoid this, make 4 an unsigned long long literal, which matches the
type of expires (u64).

Fixes: 3f12acc8d6d4 ("drm/amdgpu: put the audio codec into suspend state before gpu reset V3")
Link: ClangBuiltLinux/linux#1017
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Winteger-overflow [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickdesaulniers @nathanchance