drivers/firmware/efi/libstub/Makefile overwrites KBUILD_CFLAGS for x86[_64] #112

tpimh · 2018-09-18T18:15:13Z

These repeat a lot:

./arch/x86/include/asm/processor.h:555:17: warning: taking address of packed member 'sp0' of class or structure 'x86_hw_tss' may result in
      an unaligned pointer value [-Waddress-of-packed-member]
        this_cpu_write(cpu_tss_rw.x86_tss.sp0, sp0);
                       ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/percpu-defs.h:510:68: note: expanded from macro 'this_cpu_write'
#define this_cpu_write(pcp, val)        __pcpu_size_call(this_cpu_write_, pcp, val)
                                                                          ^~~
./include/linux/percpu-defs.h:377:22: note: expanded from macro '__pcpu_size_call'
        __verify_pcpu_ptr(&(variable));                                 \
                            ^~~~~~~~
./include/linux/percpu-defs.h:221:47: note: expanded from macro '__verify_pcpu_ptr'
        const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL;    \
                                                     ^~~

./arch/x86/include/asm/processor.h:572:30: warning: taking address of packed member 'sp1' of class or structure 'x86_hw_tss' may result in
      an unaligned pointer value [-Waddress-of-packed-member]
        return this_cpu_read_stable(cpu_current_top_of_stack);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/processor.h:379:34: note: expanded from macro 'cpu_current_top_of_stack'
#define cpu_current_top_of_stack cpu_tss_rw.x86_tss.sp1
                                 ^~~~~~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/percpu.h:392:59: note: expanded from macro 'this_cpu_read_stable'
#define this_cpu_read_stable(var)       percpu_stable_op("mov", var)
                                                                ^~~
./arch/x86/include/asm/percpu.h:219:16: note: expanded from macro 'percpu_stable_op'
                    : "p" (&(var)));                    \
                             ^~~

The text was updated successfully, but these errors were encountered:

nickdesaulniers · 2018-09-19T06:18:37Z

IIRC, this warning was disabled in the top level Makefile, but someone probably steamrolled KBUILD_CFLAGS. Can you post the .c file that triggered this warning? I'll bet 💵 that it's arch/x86/boot.

tpimh · 2018-09-19T13:33:55Z

In file included from drivers/firmware/efi/libstub/efi-stub-helper.c:13:
…

In file included from drivers/firmware/efi/libstub/gop.c:10:
…

In file included from drivers/firmware/efi/libstub/secureboot.c:12:
…

In file included from drivers/firmware/efi/libstub/tpm.c:12:
In file included from ./include/linux/efi.h:17:
In file included from ./include/linux/time.h:6:
In file included from ./include/linux/seqlock.h:36:
In file included from ./include/linux/spinlock.h:51:
In file included from ./include/linux/preempt.h:81:
In file included from ./arch/x86/include/asm/preempt.h:7:
In file included from ./include/linux/thread_info.h:38:
In file included from ./arch/x86/include/asm/thread_info.h:53:
In file included from ./arch/x86/include/asm/cpufeature.h:5:

nathanchance · 2018-09-25T20:02:41Z

Should we just apply commits 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions") and bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") to that Makefile? I know rewriting the Makefile was suggested but it seems like steamrolling the CFLAGS is intentional for x86{,_64}.

nickdesaulniers · 2018-09-25T20:39:40Z

If it was intentional, I'd be curious as to know why.

nathanchance · 2018-09-25T20:42:53Z

From the top of the Makefile:

# The stub may be linked into the kernel proper or into a separate boot binary,
# but in either case, it executes before the kernel does (with MMU disabled) so
# things like ftrace and stack-protector are likely to cause trouble if left
# enabled, even if doing so doesn't break the build.
#
cflags-$(CONFIG_X86_32)         := -march=i386
cflags-$(CONFIG_X86_64)         := -mcmodel=small
cflags-$(CONFIG_X86)            += -m$(BITS) -D__KERNEL__ -O2 \
                                   -fPIC -fno-strict-aliasing -mno-red-zone \
                                   -mno-mmx -mno-sse -fshort-wchar

I guess it could be converted to be like arm/arm64:

# arm64 uses the full KBUILD_CFLAGS so it's necessary to explicitly
# disable the s.tackleak plugin
cflags-$(CONFIG_ARM64)          := $(subst -pg,,$(KBUILD_CFLAGS)) -fpie \
                                   $(DISABLE_STACKLEAK_PLUGIN)
cflags-$(CONFIG_ARM)            := $(subst -pg,,$(KBUILD_CFLAGS)) \
                                   -fno-builtin -fpic -mno-single-pic-base

Not sure though, I'll dig through git history here shortly.

nathanchance · 2018-09-26T23:30:48Z

That steamroll has been present since the introduction of the file in commit f4f75ad ("efi: efistub: Convert into static library"). Second paragraph I'm sure it relevant.

nathanchance · 2018-10-13T01:06:41Z

Patch sent to mailing list for further discussion: https://lore.kernel.org/lkml/20181013010348.6740-1-natechancellor@gmail.com/

When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of git history. -Waddress-of-packed-member was disabled for the whole kernel in commit bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") and for x86/boot/compressed in commit 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel in commit 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") and for x86/boot/compressed in commit 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). Link: ClangBuiltLinux#112 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

dileks · 2018-10-23T07:43:33Z

OK. This is indeed a duplicate of #234. Can you please do a v2 with credits and TO/CC to maintainers (check with scripts/get_maintainer.pl)? Feel free to add my Reviewed-by/Tested-by. Thanks.

nathanchance · 2018-10-23T16:57:32Z

@dileks thanks for testing! I did send it to the proper mailing lists and maintainers and since it hasn't been more than two weeks since I sent it out, I don't think a resend/v2 is necessary just yet (especially with the merge window happening right now).

Would you like me to send a email with those tags and you CC'd to the current revision then I'll carry those in any further revisions I need to do?

dileks · 2018-10-23T17:28:59Z

OK. Ping them again? Sedat

…

On Tuesday, October 23, 2018, Nathan Chancellor ***@***.***> wrote: @dileks <https://github.com/dileks> thanks for testing! I did send it to the proper mailing lists and maintainers and since it hasn't been more than two weeks since I sent it out, I don't think a resend/v2 is necessary just yet (especially with the merge window happening right now). Would you like me to send a email with those tags and you CC'd to the current revision then I'll carry those in any further revisions I need to do? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAsJyAynO0kxQUtFAEYar6ihKC4s2cEYks5un0s7gaJpZM4WueNS> .

When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of git history. -Waddress-of-packed-member was disabled for the whole kernel in commit bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") and for x86/boot/compressed in commit 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel in commit 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") and for x86/boot/compressed in commit 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). Link: ClangBuiltLinux/linux#112 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Tested-by: Nick Desaulniers <ndesaulniers@google.com> (am from https://lore.kernel.org/patchwork/patch/999058/) (also found at https://lkml.kernel.org/r/20181013010348.6740-1-natechancellor@gmail.com) BUG=chromium:897984 TEST=build for lakitu Change-Id: Ibe18a22243f5c99c3ceb5b93f8a648ffaa1c7f66 Signed-off-by: Guenter Roeck <groeck@chromium.org>

nathanchance · 2018-11-05T16:54:47Z

Patch accepted: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/commit/?id=b01b9dfaee3c47cbfae0842a591b504f3cecfbdb

When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of git history. -Waddress-of-packed-member was disabled for the whole kernel in commit bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") and for x86/boot/compressed in commit 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel in commit 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") and for x86/boot/compressed in commit 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). Link: ClangBuiltLinux/linux#112 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of git history. -Waddress-of-packed-member was disabled for the whole kernel in commit bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") and for x86/boot/compressed in commit 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel in commit 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") and for x86/boot/compressed in commit 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). Link: ClangBuiltLinux#112 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of Git history. -Waddress-of-packed-member was disabled for the whole kernel and for the early boot code in these commits: bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel and for the early boot code in these commits: 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). [ mingo: Made the changelog more readable. ] Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Bhupesh Sharma <bhsharma@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Eric Snowberg <eric.snowberg@oracle.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Joe Perches <joe@perches.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: YiFei Zhu <zhuyifei1999@gmail.com> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20181129171230.18699-8-ard.biesheuvel@linaro.org Link: ClangBuiltLinux#112 Signed-off-by: Ingo Molnar <mingo@kernel.org>

nathanchance · 2018-12-27T15:32:42Z

Merged into mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3db5e0ba8b8f4aee631d7ee04b7a11c56cfdc213

[ Upstream commit 3db5e0b ] When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of Git history. -Waddress-of-packed-member was disabled for the whole kernel and for the early boot code in these commits: bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel and for the early boot code in these commits: 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). [ mingo: Made the changelog more readable. ] Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Bhupesh Sharma <bhsharma@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Eric Snowberg <eric.snowberg@oracle.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Joe Perches <joe@perches.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: YiFei Zhu <zhuyifei1999@gmail.com> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20181129171230.18699-8-ard.biesheuvel@linaro.org Link: ClangBuiltLinux/linux#112 Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>

[ Upstream commit 3db5e0ba8b8f4aee631d7ee04b7a11c56cfdc213 ] When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of Git history. -Waddress-of-packed-member was disabled for the whole kernel and for the early boot code in these commits: bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel and for the early boot code in these commits: 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). [ mingo: Made the changelog more readable. ] Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Bhupesh Sharma <bhsharma@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Eric Snowberg <eric.snowberg@oracle.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Joe Perches <joe@perches.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: YiFei Zhu <zhuyifei1999@gmail.com> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20181129171230.18699-8-ard.biesheuvel@linaro.org Link: ClangBuiltLinux/linux#112 Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>

commit 3db5e0ba8b8f4aee631d7ee04b7a11c56cfdc213 upstream. When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of Git history. -Waddress-of-packed-member was disabled for the whole kernel and for the early boot code in these commits: bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel and for the early boot code in these commits: 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). [ mingo: Made the changelog more readable. ] Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Bhupesh Sharma <bhsharma@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Eric Snowberg <eric.snowberg@oracle.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Joe Perches <joe@perches.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: YiFei Zhu <zhuyifei1999@gmail.com> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20181129171230.18699-8-ard.biesheuvel@linaro.org Link: ClangBuiltLinux/linux#112 Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

[ Upstream commit 3db5e0b ] When building the kernel with Clang, some disabled warnings appear because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to this list so that the build is clean again. -Wpointer-sign was disabled for the whole kernel before the beginning of Git history. -Waddress-of-packed-member was disabled for the whole kernel and for the early boot code in these commits: bfb3898 ("kbuild: clang: Disable 'address-of-packed-member' warning") 20c6c18 ("x86/boot: Disable the address-of-packed-member compiler warning"). -Wgnu was disabled for the whole kernel and for the early boot code in these commits: 61163ef ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang") 6c3b56b ("x86/boot: Disable Clang warnings about GNU extensions"). [ mingo: Made the changelog more readable. ] Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Bhupesh Sharma <bhsharma@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Eric Snowberg <eric.snowberg@oracle.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Joe Perches <joe@perches.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: YiFei Zhu <zhuyifei1999@gmail.com> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20181129171230.18699-8-ard.biesheuvel@linaro.org Link: ClangBuiltLinux/linux#112 Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>

serial core expects the spinlock to be initialized by the controller driver for serial console, this patch makes sure the spinlock is initialized, fixing the below issue: [ 0.865928] BUG: spinlock bad magic on CPU#0, swapper/0/1 [ 0.865945] lock: sci_ports+0x0/0x4c80, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 [ 0.865955] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc1+ #112 [ 0.865961] Hardware name: HopeRun HiHope RZ/G2H with sub board (DT) [ 0.865968] Call trace: [ 0.865979] dump_backtrace+0x0/0x1d8 [ 0.865985] show_stack+0x14/0x20 [ 0.865996] dump_stack+0xe8/0x130 [ 0.866006] spin_dump+0x6c/0x88 [ 0.866012] do_raw_spin_lock+0xb0/0xf8 [ 0.866023] _raw_spin_lock_irqsave+0x80/0xa0 [ 0.866032] uart_add_one_port+0x3a4/0x4e0 [ 0.866039] sci_probe+0x504/0x7c8 [ 0.866048] platform_drv_probe+0x50/0xa0 [ 0.866059] really_probe+0xdc/0x330 [ 0.866066] driver_probe_device+0x58/0xb8 [ 0.866072] device_driver_attach+0x6c/0x90 [ 0.866078] __driver_attach+0x88/0xd0 [ 0.866085] bus_for_each_dev+0x74/0xc8 [ 0.866091] driver_attach+0x20/0x28 [ 0.866098] bus_add_driver+0x14c/0x1f8 [ 0.866104] driver_register+0x60/0x110 [ 0.866109] __platform_driver_register+0x40/0x48 [ 0.866119] sci_init+0x2c/0x34 [ 0.866127] do_one_initcall+0x88/0x428 [ 0.866137] kernel_init_freeable+0x2c0/0x328 [ 0.866143] kernel_init+0x10/0x108 [ 0.866150] ret_from_fork+0x10/0x18 Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Fixes: a3cb39d ("serial: core: Allow detach and attach serial device for console") Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/1593618100-2151-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

tpimh added [BUG] linux A bug that should be fixed in the mainline kernel. low priority This bug is not critical and not a priority labels Sep 18, 2018

tpimh added the [ARCH] x86_64 This bug impacts ARCH=x86_64 label Sep 19, 2018

nickdesaulniers changed the title ~~-Waddress-of-packed-member in arch/x86/include/asm/processor.h~~ drivers/firmware/efi/libstub/Makefile overwrites KBUILD_CFLAGS for x86[_64] Sep 24, 2018

nickdesaulniers mentioned this issue Sep 24, 2018

-Wgnu-variable-sized-type-not-at-end in include/linux/cgroup-defs.h #113

Closed

nathanchance self-assigned this Oct 13, 2018

nathanchance added [PATCH] Submitted A patch has been submitted for review and removed low priority This bug is not critical and not a priority labels Oct 13, 2018

nathanchance mentioned this issue Oct 13, 2018

-Wpointer-sign in arch/x86/boot/compressed #215

Closed

nathanchance mentioned this issue Oct 22, 2018

arch/x86/include/asm/processor.h: Warning -Waddress-of-packed-member #234

Closed

nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Nov 5, 2018

nathanchance closed this as completed Dec 27, 2018

nathanchance added [FIXED][LINUX] 5.0 This bug was fixed in Linux 5.0 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Dec 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers/firmware/efi/libstub/Makefile overwrites KBUILD_CFLAGS for x86[_64] #112

drivers/firmware/efi/libstub/Makefile overwrites KBUILD_CFLAGS for x86[_64] #112

tpimh commented Sep 18, 2018

nickdesaulniers commented Sep 19, 2018

tpimh commented Sep 19, 2018 •

edited

Loading

nathanchance commented Sep 25, 2018

nickdesaulniers commented Sep 25, 2018

nathanchance commented Sep 25, 2018

nathanchance commented Sep 26, 2018

nathanchance commented Oct 13, 2018

dileks commented Oct 23, 2018

nathanchance commented Oct 23, 2018

dileks commented Oct 23, 2018 via email

nathanchance commented Nov 5, 2018

nathanchance commented Dec 27, 2018

drivers/firmware/efi/libstub/Makefile overwrites KBUILD_CFLAGS for x86[_64] #112

drivers/firmware/efi/libstub/Makefile overwrites KBUILD_CFLAGS for x86[_64] #112

Comments

tpimh commented Sep 18, 2018

nickdesaulniers commented Sep 19, 2018

tpimh commented Sep 19, 2018 • edited Loading

nathanchance commented Sep 25, 2018

nickdesaulniers commented Sep 25, 2018

nathanchance commented Sep 25, 2018

nathanchance commented Sep 26, 2018

nathanchance commented Oct 13, 2018

dileks commented Oct 23, 2018

nathanchance commented Oct 23, 2018

dileks commented Oct 23, 2018 via email

nathanchance commented Nov 5, 2018

nathanchance commented Dec 27, 2018

tpimh commented Sep 19, 2018 •

edited

Loading