Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wtentative-definition-incomplete-type in drivers/regulator/max77650-regulator.c #491

Closed
nathanchance opened this issue May 23, 2019 · 2 comments
Closed

-Wtentative-definition-incomplete-type in drivers/regulator/max77650-regulator.c #491

nathanchance opened this issue May 23, 2019 · 2 comments
Assignees
@nathanchance
Labels
-Wtentative-definition-incomplete-type [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/regulator/max77650-regulator.c:32:39: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct max77650_regulator_desc' [-Wtentative-definition-incomplete-type]
static struct max77650_regulator_desc max77651_SBB1_desc;
                                      ^
drivers/regulator/max77650-regulator.c:32:15: note: forward declaration of 'struct max77650_regulator_desc'
static struct max77650_regulator_desc max77651_SBB1_desc;
              ^
1 warning generated.

Patch sent: https://lore.kernel.org/lkml/20190523012629.7707-1-natechancellor@gmail.com/
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next -Wtentative-definition-incomplete-type labels May 23, 2019
@nathanchance nathanchance self-assigned this May 23, 2019
broonie pushed a commit to broonie/regulator that referenced this issue May 23, 2019
@nathanchance @broonie
regulator: max77650: Move max77651_SBB1_desc's declaration down
59dec1f 
Clang warns:

drivers/regulator/max77650-regulator.c:32:39: warning: tentative
definition of variable with internal linkage has incomplete non-array
type 'struct max77650_regulator_desc'
[-Wtentative-definition-incomplete-type]
static struct max77650_regulator_desc max77651_SBB1_desc;
                                      ^
drivers/regulator/max77650-regulator.c:32:15: note: forward declaration
of 'struct max77650_regulator_desc'
static struct max77650_regulator_desc max77651_SBB1_desc;
              ^
1 warning generated.

Move max77651_SBB1_desc's declaration below max77650_regulator_desc's
definition so this warning does not happen.

Fixes: 3df4235 ("regulator: max77650: Convert MAX77651 SBB1 to pickable linear range")
Link: ClangBuiltLinux/linux#491
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
@nathanchance
Copy link
Member Author

Patch accepted: https://git.kernel.org/broonie/regulator/c/59dec1f0fac8107f3bffaa0051afce795e24c3e4

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels May 23, 2019
@nathanchance
Copy link
Member Author

Fixed: https://git.kernel.org/next/linux-next/c/59dec1f0fac8107f3bffaa0051afce795e24c3e4

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wtentative-definition-incomplete-type [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance