Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wincompatible-pointer-types in drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c #632

Closed
nathanchance opened this issue Aug 7, 2019 · 2 comments
Closed

-Wincompatible-pointer-types in drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c #632

nathanchance opened this issue Aug 7, 2019 · 2 comments
Assignees
@nathanchance
Labels
-Wincompatible-pointer-types [ARCH] arm32 This bug impacts ARCH=arm [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2325:9: error: incompatible pointer types initializing 'int (*)(struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)' with an expression of type 'int (const struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)' [-Werror,-Wincompatible-pointer-types]
        .set = aspeed_g6_sig_expr_set,
               ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Patch submitted: https://lore.kernel.org/lkml/20190807003037.48457-1-natechancellor@gmail.com/
@nathanchance nathanchance added [ARCH] arm32 This bug impacts ARCH=arm [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next -Wincompatible-pointer-types labels Aug 7, 2019
@nathanchance nathanchance self-assigned this Aug 7, 2019
@nathanchance
Copy link
Member Author

Patch accepted: https://git.kernel.org/linusw/linux-pinctrl/c/21b2920fb587e570b43973300a11b921c3a61d3e

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Aug 10, 2019
@nathanchance
Copy link
Member Author

Fixed: https://git.kernel.org/next/linux-next/c/21b2920fb587e570b43973300a11b921c3a61d3e

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Aug 12, 2019
shenki pushed a commit to shenki/linux that referenced this issue Sep 16, 2019
@nathanchance @shenki
pinctrl: aspeed: g6: Remove const specifier from aspeed_g6_sig_expr_s…
1b0d34a 
…et's ctx parameter

clang errors:

drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2325:9: error: incompatible
pointer types initializing 'int (*)(struct aspeed_pinmux_data *, const
struct aspeed_sig_expr *, bool)' with an expression of type 'int (const
struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)'
[-Werror,-Wincompatible-pointer-types]
        .set = aspeed_g6_sig_expr_set,
               ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Commit 674fa8d ("pinctrl: aspeed-g5: Delay acquisition of regmaps")
changed the set function pointer declaration and the g6 one wasn't
updated (I assume because it wasn't merged yet).

Fixes: 2eda1cd ("pinctrl: aspeed: Add AST2600 pinmux support")
Link: ClangBuiltLinux#632
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20190807003037.48457-1-natechancellor@gmail.com
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(cherry picked from commit 21b2920)
Signed-off-by: Joel Stanley <joel@jms.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wincompatible-pointer-types [ARCH] arm32 This bug impacts ARCH=arm [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance