Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wpointer-bool-conversion in drivers/net/ethernet/intel/i40e/i40e_debugfs.c #82

Closed
shenki opened this issue Sep 17, 2018 · 3 comments
Closed

-Wpointer-bool-conversion in drivers/net/ethernet/intel/i40e/i40e_debugfs.c #82

shenki opened this issue Sep 17, 2018 · 3 comments
Assignees
@nathanchance
Labels
-Wpointer-bool-conversion [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 4.20 This bug was fixed in Linux 4.20

Comments

@shenki
Copy link
Member

shenki commented Sep 17, 2018 

drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address of array 'vsi->active_vlans' will
      always evaluate to 'true' [-Wpointer-bool-conversion]
                 vsi->active_vlans ? "<valid>" : "<null>");
                 ~~~~~^~~~~~~~~~~~ ~
./include/linux/device.h:1424:33: note: expanded from macro 'dev_info'
        _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                       ^~~~~~~~~~~
@shenki shenki added help wanted good first issue Good for newcomers [BUG] linux A bug that should be fixed in the mainline kernel. and removed low priority This bug is not critical and not a priority labels Sep 17, 2018
@tpimh tpimh added low priority This bug is not critical and not a priority -Wpointer-bool-conversion labels Sep 18, 2018
@nathanchance
Copy link
Member

Patch sent: https://lore.kernel.org/lkml/20180921193907.4864-1-natechancellor@gmail.com/

@nathanchance nathanchance self-assigned this Sep 21, 2018
@nathanchance nathanchance added the [PATCH] Submitted A patch has been submitted for review label Sep 21, 2018
fengguang pushed a commit to 0day-ci/linux that referenced this issue Sep 22, 2018
@nathanchance @intel-lab-lkp
i40e: Remove unnecessary print statement
5566a1f 
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address
of array 'vsi->active_vlans' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                 vsi->active_vlans ? "<valid>" : "<null>");
                 ~~~~~^~~~~~~~~~~~ ~
./include/linux/device.h:1431:33: note: expanded from macro 'dev_info'
        _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                       ^~~~~~~~~~~
1 warning generated.

Given that the statement shows that active_vlans is always valid, just
remove the statement since it's not giving any useful information.

Link: ClangBuiltLinux#82
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
@tpimh tpimh removed the good first issue Good for newcomers label Sep 25, 2018
@nathanchance
Copy link
Member

Patch accepted: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/commit/?id=6b26eca83d961d6b0140c70bedfac504d536a8c3

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Sep 25, 2018
alaahl pushed a commit to alaahl/linux that referenced this issue Oct 4, 2018
@nathanchance
i40e: Remove unnecessary print statement
92fb7aa 
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address
of array 'vsi->active_vlans' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                 vsi->active_vlans ? "<valid>" : "<null>");
                 ~~~~~^~~~~~~~~~~~ ~
./include/linux/device.h:1431:33: note: expanded from macro 'dev_info'
        _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                       ^~~~~~~~~~~
1 warning generated.

Given that the statement shows that active_vlans is always valid, just
remove the statement since it's not giving any useful information.

Link: ClangBuiltLinux#82
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
@nathanchance
Copy link
Member

Merged into mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=92fb7aaff8dd18636cb999a5878508124cc76ac5

@nathanchance nathanchance added [FIXED][LINUX] 4.20 This bug was fixed in Linux 4.20 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Oct 25, 2018
@tpimh tpimh removed the low priority This bug is not critical and not a priority label Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wpointer-bool-conversion [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 4.20 This bug was fixed in Linux 4.20
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shenki @tpimh @nickdesaulniers @nathanchance