Inline headers in ROOT dictionaries #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2017
calcuttj
pushed a commit
to calcuttj/edep-sim
that referenced
this pull request
Oct 4, 2024
Synchronise the bomb and master branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
ROOT6 dictionaries are apparently generated with absolute paths to header files hard coded. There's some new autoloading mechanism which wants these headers. If the build source area goes away, these become dangling references.
One solution is to tell
rootclingto inline the header file contents which this PR does by passing the option-inlineInputHeaderthrough thecmakemacro that runsrootcling.Another solution is maybe to use
-noIncludePaths. I guess this is good that it makes the dictionaries smaller but at the cost that one has to install the header files and setROOT_INCLUDE_PATH. This doesn't seem like a good tradeoff.