Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code / clean codebase #41

Open
timbocode opened this issue Jan 25, 2020 · 0 comments
Open

Remove redundant code / clean codebase #41

timbocode opened this issue Jan 25, 2020 · 0 comments
Assignees
Labels
Maintenance Compatibility with PHP or MySQL etc. and other general codebase issues.

Comments

@timbocode
Copy link
Contributor

timbocode commented Jan 25, 2020

Although much of the code from the parts of Rank Math not carried over to Classic SEO have already been removed, it is known that some redundant code remains, particularly in JS and CSS.

The opportunity should be taken to remove any code that is specific to PHP 5.6 as Classic SEO does not support any version of PHP below 7.0.

Similarly, the entire codebase needs to be examined to see where improvements and efficiencies can be made.

Massive amount of CPSEO settings appear in Post's Custom Metadata is potentially an area where such improvements can be made. Although PR #76 partially addresses this issue, it only hides the meta data but does not stop it from being created. Ways of reducing the amount of data will be examined as part of issue 41.

@timbocode timbocode added the Maintenance Compatibility with PHP or MySQL etc. and other general codebase issues. label Jan 25, 2020
@timbocode timbocode self-assigned this Jan 25, 2020
timbocode added a commit that referenced this issue Jul 30, 2020
Only a basic tidy and a still-readable minify. Two duplicate rules removed. Nothing more. A full CSS cleanup will be performed as part of #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Compatibility with PHP or MySQL etc. and other general codebase issues.
Projects
None yet
Development

No branches or pull requests

1 participant