Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/own enumerable #1

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Feature/own enumerable #1

merged 10 commits into from
Aug 23, 2023

Conversation

ClaudiaRojasSoto
Copy link
Owner

Description

Own-enumerable feature branch, implementing a custom enumerable module within a Ruby class. Create a class MyList and a module MyEnumerable. Implement a subset of Enumerable's functionality, including the methods #all? , #any?, and #filter.

General Requirements:

  • Ensure no linter errors.
  • Follow the correct GitHub Flow.
  • Document work in a professional manner.

Ruby Requirements:

  • Adhere to the list of best practices for Ruby.

  • Check official documentation for the methods in Enumerable.

  • Create a class MyList with an instance variable @list.

  • Implement a method #each in MyList that yields successive members of @list and uses the MyEnumerable module.

  • Create a module MyEnumerable that implements the following methods with the same functionality as methods in Enumerable:

  • #all?

  • #any?

  • #filter

  • Separate each class and module into individual .rb files.

Please review and verify the work in this branch to ensure it meets all requirements. Your expertise and feedback are vital for the success of this feature. We appreciate your time and any comments you may have to improve our work.

Thank you in advance and greetings,
@CesarHerr
@ClaudiaRojasSoto

@ClaudiaRojasSoto ClaudiaRojasSoto added the enhancement New feature or request label Aug 23, 2023
Copy link

@usorfaitheloho usorfaitheloho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClaudiaRojasSoto ,

STATUS: APPROVED! 🥇 💯

done

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ClaudiaRojasSoto
Copy link
Owner Author

Thank you @usorfaitheloho!

@ClaudiaRojasSoto ClaudiaRojasSoto merged commit 389809d into develop Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants