Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flake8-putty to allow existing flake8 errors #107

Merged
merged 1 commit into from
Feb 13, 2016

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 2, 2015

Records existing errors per file, for many common
flake8 plugins, preventing new flake8 errors.

Records existing errors per file, for many common
flake8 plugins, preventing new flake8 errors.
@e3krisztian
Copy link
Contributor

AFAIK (a user here) green currently has no published coding style.
It has no checks on commit for it (travis).
That means it has lots of different pep8/pyflake/flake8 style errors as can be seen from the ignored error list in your patch.

I think the next step would be choosing a coding style and adjusting the code/infrastructure for it.

Could you provide some argument why is covering up yet unknown stylistic errors important at this point?

@jayvdb jayvdb mentioned this pull request Dec 2, 2015
@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 2, 2015

This PR, using flake8-putty, provides the maintainers with a tool to decide which pep8 rules (and flake8 extensions) should be ignored globally as undesirable, with exceptions for specific cases where the desirable rules should be ignored.

This patch provides a clearly documented list of existing 'violations' in a way that they can be discussed.

I've pre-selected a global ignore list for codes which appear to be undesirable based on existing coding style. I am more than happy to amend this patch as required to match the maintainers rough coding style preferences.

This approach allows the gradual improvement of coding style, instead of large numbers of style-only changes to immediately implement a coding style. If the maintainers would prefer a big bang approach to adopting a coding style, I am happy to abandon this. If the maintainers dont want to pick a coding style, then they can close this.

My reason for initiating this PR (and creating the flake8 extensions) is that I find it a waste of my time to contribute large patches to projects without any clear direction on coding style. As I'd like to contribute to the project, I'd prefer to get some baseline decisions in place regarding coding style.

CleanCut added a commit that referenced this pull request Feb 13, 2016
Use flake8-putty to allow existing flake8 errors
@CleanCut CleanCut merged commit 67126c4 into CleanCut:master Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants