Crash on syntax error while loading test files #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop silently ignoring crashes on some loading paths. Notably, when you specified a dotname for the target to test and the module had a syntax error, then the module was being silently skipped. - This changes the behavior when targets are being loaded by filename and have a syntax error. Previously we were converting the syntax error into a single test failure representing failing to load the module. Now the crash occurs before we get that far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you specified a dotname for the target to test and the module had a
syntax error, then the module was being silently skipped.
and have a syntax error. Previously we were converting the syntax
error into a single test failure representing failing to load the
module. Now the crash occurs before we get that far.
Separately, I removed the GitHub action that tries to add a special label for my sponsors.
Resolves #255