Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Python 3.12 #274

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix for Python 3.12 #274

merged 2 commits into from
Dec 4, 2023

Conversation

CleanCut
Copy link
Owner

@CleanCut CleanCut commented Dec 3, 2023

Resolves #272

Copy link
Collaborator

@sodul sodul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sodul added a commit to clumio-oss/green that referenced this pull request Dec 4, 2023
This is new to python 3.12 and throws warning on every single test. This adds the new method and related property. Longer term we should probably inherit from the official TestResult class as to ensure better forward compatibility.

This depends on CleanCut#274.
sodul added a commit to clumio-oss/green that referenced this pull request Dec 4, 2023
This is new to python 3.12 and throws warning on every single test. This adds the new method and related property. Longer term we should probably inherit from the official TestResult class as to ensure better forward compatibility.

This depends on CleanCut#274.
sodul added a commit to clumio-oss/green that referenced this pull request Dec 4, 2023
This is new to python 3.12 and throws warning on every single test. This adds the new method and related property. Longer term we should probably inherit from the official TestResult class as to ensure better forward compatibility.

This depends on CleanCut#274.
@CleanCut CleanCut merged commit 06d53db into main Dec 4, 2023
15 checks passed
@CleanCut CleanCut deleted the python3.12 branch December 4, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 support
2 participants