Skip to content

Commit 5d30503

Browse files
author
Jacek Jagiello
committed
PHPGL-30 Renamed commands
1 parent 6c92774 commit 5d30503

12 files changed

+69
-70
lines changed

‎src/Bundle/BaseInteractiveCommand.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
66
use Symfony\Component\Console\Input\InputInterface;
77
use Symfony\Component\Console\Output\OutputInterface;
8-
use tests\Clearcode\CommandBusConsole\Bundle\Type\DummyCommandType;
8+
use tests\Clearcode\CommandBusConsole\Bundle\Type\SignUpUserType;
99

1010
class BaseInteractiveCommand extends ContainerAwareCommand
1111
{
1212
private static $commandToFormTypeMap = [
13-
'DummyCommand' => DummyCommandType::class,
13+
'DummyCommand' => SignUpUserType::class,
1414
];
1515

1616
/**

‎src/Bundle/Command/CommandBusInteractiveConsoleCommand.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Symfony\Component\Console\Input\InputArgument;
88
use Symfony\Component\Console\Input\InputInterface;
99
use Symfony\Component\Console\Output\OutputInterface;
10-
use tests\Clearcode\CommandBusConsole\Bundle\Type\DummyCommandType;
10+
use tests\Clearcode\CommandBusConsole\Bundle\Type\SignUpUserType;
1111

1212
class CommandBusInteractiveConsoleCommand extends ContainerAwareCommand
1313
{
@@ -17,7 +17,7 @@ class CommandBusInteractiveConsoleCommand extends ContainerAwareCommand
1717
const INTERACTIVE_COMMAND = 'command-bus:handle';
1818

1919
private static $commandToFormTypeMap = [
20-
'DummyCommand' => DummyCommandType::class,
20+
'DummyCommand' => SignUpUserType::class,
2121
];
2222

2323
protected function configure()

‎tests/Bundle/App/config.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ framework:
88
form: ~
99

1010
services:
11-
dummy_command:
12-
class: tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommandHandler
11+
send_invitation:
12+
class: tests\Clearcode\CommandBusConsole\Bundle\Mocks\SendInvitationHandler
1313
tags:
14-
- { name: command_handler, handles: tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommand }
14+
- { name: command_handler, handles: tests\Clearcode\CommandBusConsole\Bundle\Mocks\SendInvitation }

‎tests/Bundle/Command/CommandBusLaunchCommandTest.php‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,19 @@
44

55
use Clearcode\CommandBusConsole\Bundle\Command\CommandBusConsoleCommand;
66
use tests\Clearcode\CommandBusConsole\Bundle\CLITestCase;
7-
use tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommand;
7+
use tests\Clearcode\CommandBusConsole\Bundle\Mocks\SendInvitation;
88

99
class CommandBusLaunchCommandTest extends CLITestCase
1010
{
1111
/** @test */
1212
public function it_should_execute_command_with_success()
1313
{
1414
$this->executeCommand(new CommandBusConsoleCommand(), [
15-
'commandName' => 'DummyCommand',
16-
'arguments' => [DummyCommand::HANDLING_WITH_SUCCESS],
15+
'commandName' => 'SendInvitation',
16+
'arguments' => [SendInvitation::HANDLING_WITH_SUCCESS],
1717
]);
1818

1919
$this->assertThatStatusCodeEquals(CommandBusConsoleCommand::SUCCESS_CODE);
20-
$this->assertThatOutputContains('executed with success');
2120
}
2221

2322
/** @test */
@@ -37,23 +36,21 @@ public function it_display_an_error_when_required_arguments_was_not_provided()
3736
$this->markTestIncomplete();
3837

3938
$this->executeCommand(new CommandBusConsoleCommand(), [
40-
'commandName' => 'DummyCommand',
39+
'commandName' => 'SendInvitation',
4140
'arguments' => [],
4241
]);
4342

4443
$this->assertThatStatusCodeEquals(CommandBusConsoleCommand::ERROR_CODE);
45-
$this->assertThatOutputContains('An unexpected error occurred.');
4644
}
4745

4846
/** @test */
4947
public function it_display_an_error_when_executing_command_will_fail()
5048
{
5149
$this->executeCommand(new CommandBusConsoleCommand(), [
52-
'commandName' => 'DummyCommand',
53-
'arguments' => [DummyCommand::HANDLING_WITH_FAIL],
50+
'commandName' => 'NonExistingCommand',
51+
'arguments' => [SendInvitation::HANDLING_WITH_FAIL],
5452
]);
5553

5654
$this->assertThatStatusCodeEquals(CommandBusConsoleCommand::ERROR_CODE);
57-
$this->assertThatOutputContains('An unexpected error occurred.');
5855
}
5956
}

‎tests/Bundle/Mocks/DummyCommand.php‎ renamed to ‎tests/Bundle/Mocks/SendInvitation.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace tests\Clearcode\CommandBusConsole\Bundle\Mocks;
44

5-
class DummyCommand
5+
class SendInvitation
66
{
77
const HANDLING_WITH_SUCCESS = 'HANDLING_WITH_SUCCESS';
88
const HANDLING_WITH_FAIL = 'HANDLING_WITH_FAIL';

‎tests/Bundle/Mocks/DummyCommandHandler.php‎ renamed to ‎tests/Bundle/Mocks/SendInvitationHandler.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
namespace tests\Clearcode\CommandBusConsole\Bundle\Mocks;
44

5-
class DummyCommandHandler
5+
class SendInvitationHandler
66
{
77
/**
8-
* @param DummyCommand $command
8+
* @param SendInvitation $command
99
*
1010
* @throws \Exception
1111
*/
12-
public function handle(DummyCommand $command)
12+
public function handle(SendInvitation $command)
1313
{
14-
if ($command->argument1 == DummyCommand::HANDLING_WITH_FAIL) {
14+
if ($command->argument1 == SendInvitation::HANDLING_WITH_FAIL) {
1515
throw new \Exception('An unexpected error occurred.');
1616
}
1717
}

‎tests/Bundle/Type/DummyCommandType.php‎ renamed to ‎tests/Bundle/Type/SignUpUserType.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,26 @@
77
use Symfony\Component\Form\FormInterface;
88
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
99
use Symfony\Component\Validator\Constraints as Assert;
10-
use tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommand;
10+
use tests\Clearcode\CommandBusConsole\Bundle\Mocks\SendInvitation;
1111

12-
class DummyCommandType extends AbstractType
12+
class SignUpUserType extends AbstractType
1313
{
1414
/**
1515
* {@inheritdoc}
1616
*/
1717
public function buildForm(FormBuilderInterface $builder, array $options)
1818
{
19-
$builder->add('argument1', 'text', [
19+
$builder->add('email', 'text', [
2020
'label' => 'What\'s first argument?',
2121
]);
2222
}
2323

2424
public function setDefaultOptions(OptionsResolverInterface $resolver)
2525
{
2626
$resolver->setDefaults([
27-
'data_class' => DummyCommand::class,
27+
'data_class' => SendInvitation::class,
2828
'empty_data' => function (FormInterface $form) {
29-
return new DummyCommand($form->get('argument1')->getData());
29+
return new SendInvitation($form->get('argument1')->getData());
3030
},
3131
]);
3232
}

‎tests/CommandCollectorTest.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Clearcode\CommandBusConsole\CommandCollector;
66
use Clearcode\CommandBusConsole\CommandReflection;
7-
use tests\Clearcode\CommandBusConsole\Mocks\DummyCommand;
7+
use tests\Clearcode\CommandBusConsole\Mocks\SignUpUser;
88

99
class CommandCollectorTest extends \PHPUnit_Framework_TestCase
1010
{
@@ -26,8 +26,8 @@ public function it_process_command_services()
2626
$this->sut->processCommandServices($this->commands);
2727

2828
\PHPUnit_Framework_Assert::assertEquals(
29-
'DummyCommand',
30-
$this->sut->getCommandByName('DummyCommand')->commandName
29+
'SignUpUser',
30+
$this->sut->getCommandByName('SignUpUser')->commandName
3131
);
3232
}
3333

@@ -38,7 +38,7 @@ public function it_returns_command_reflection_by_command_name()
3838
{
3939
$this->sut->processCommandServices($this->commands);
4040

41-
$command = $this->sut->getCommandByName('DummyCommand');
41+
$command = $this->sut->getCommandByName('SignUpUser');
4242

4343
\PHPUnit_Framework_Assert::assertInstanceOf(CommandReflection::class, $command);
4444
}
@@ -59,7 +59,7 @@ public function setUp()
5959
$this->sut = new CommandCollector();
6060

6161
$this->commands = [
62-
DummyCommand::class,
62+
SignUpUser::class,
6363
];
6464
}
6565
}

‎tests/CommandLauncherTest.php‎

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
use Clearcode\CommandBusConsole\CommandCollector;
77
use Clearcode\CommandBusConsole\CommandLauncher;
88
use Clearcode\CommandBusConsole\CommandReflection;
9+
use Prophecy\Argument;
910
use Ramsey\Uuid\Uuid;
10-
use tests\Clearcode\CommandBusConsole\Mocks\DummyCommand;
11+
use tests\Clearcode\CommandBusConsole\Mocks\SignUpUser;
1112
use tests\Clearcode\CommandBusConsole\Mocks\DummyCommandWithUuid;
1213

1314
class CommandLauncherTest extends \PHPUnit_Framework_TestCase
@@ -23,18 +24,19 @@ class CommandLauncherTest extends \PHPUnit_Framework_TestCase
2324
/** @test */
2425
public function it_returns_command_with_integer_to_launch()
2526
{
26-
$this->commandCollector->getCommandByName('DummyCommand')->willReturn(
27-
CommandReflection::fromClass(DummyCommand::class)
27+
$this->commandCollector->getCommandByName('SignUpUser')->willReturn(
28+
CommandReflection::fromClass(SignUpUser::class)
2829
);
2930

30-
$this->argumentsProcessor->process(['lorem ipsum', '123'])->willReturn(
31-
['lorem ipsum', 123]
31+
$this->argumentsProcessor->process(Argument::any())->willReturn(
32+
['Jacek Jagiello', 'j.jagiello@clearcode.cc']
3233
);
3334

34-
$command = $this->sut->getCommandToLaunch('DummyCommand', ['lorem ipsum', 123]);
35+
$command = $this->sut->getCommandToLaunch('SignUpUser', ['Jacek Jagiello', 'j.jagiello@clearcode.cc']);
3536

36-
$this->assertInstanceOf(DummyCommand::class, $command);
37-
$this->assertTrue(123 === $command->argument2);
37+
$this->assertInstanceOf(SignUpUser::class, $command);
38+
$this->assertTrue('Jacek Jagiello' === $command->fullName);
39+
$this->assertTrue('j.jagiello@clearcode.cc' === $command->email);
3840
}
3941

4042
/** @test */
@@ -57,11 +59,11 @@ public function it_returns_command_with_uuid_to_launch()
5759
/** @test */
5860
public function it_returns_command_reflection()
5961
{
60-
$this->commandCollector->getCommandByName('DummyCommand')->willReturn(
61-
CommandReflection::fromClass(DummyCommand::class)
62+
$this->commandCollector->getCommandByName('SignUpUser')->willReturn(
63+
CommandReflection::fromClass(SignUpUser::class)
6264
);
6365

64-
$commandReflection = $this->sut->getCommandReflection('DummyCommand');
66+
$commandReflection = $this->sut->getCommandReflection('SignUpUser');
6567

6668
$this->assertInstanceOf(CommandReflection::class, $commandReflection);
6769
}

‎tests/CommandReflectionTest.php‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Clearcode\CommandBusConsole\ValueConverter\IntConverter;
88
use Clearcode\CommandBusConsole\ValueConverter\UuidConverter;
99
use Ramsey\Uuid\Uuid;
10-
use tests\Clearcode\CommandBusConsole\Mocks\DummyCommand;
10+
use tests\Clearcode\CommandBusConsole\Mocks\SignUpUser;
1111
use tests\Clearcode\CommandBusConsole\Mocks\DummyCommandWithUuid;
1212

1313
class CommandReflectionTest extends \PHPUnit_Framework_TestCase
@@ -17,7 +17,7 @@ class CommandReflectionTest extends \PHPUnit_Framework_TestCase
1717
*/
1818
public function it_can_be_created_from_class_name()
1919
{
20-
$commandReflection = CommandReflection::fromClass(DummyCommand::class);
20+
$commandReflection = CommandReflection::fromClass(SignUpUser::class);
2121

2222
\PHPUnit_Framework_Assert::assertInstanceOf(CommandReflection::class, $commandReflection);
2323
}
@@ -28,14 +28,14 @@ public function it_can_be_created_from_class_name()
2828
public function it_returns_new_command_instance()
2929
{
3030
$argumentProcessor = new ArgumentsProcessor([new IntConverter()]);
31-
$commandReflection = CommandReflection::fromClass(DummyCommand::class);
31+
$commandReflection = CommandReflection::fromClass(SignUpUser::class);
3232

33-
$commandParameters = ['lorem ipsum', '2'];
33+
$commandParameters = ['Jacek Jagiello', 'j.jagiello@clearcode.cc'];
3434
$command = $commandReflection->createCommand($commandParameters, $argumentProcessor);
3535

36-
\PHPUnit_Framework_Assert::assertInstanceOf(DummyCommand::class, $command);
37-
\PHPUnit_Framework_Assert::assertEquals('lorem ipsum', $command->argument1);
38-
\PHPUnit_Framework_Assert::assertTrue(2 === $command->argument2);
36+
\PHPUnit_Framework_Assert::assertInstanceOf(SignUpUser::class, $command);
37+
\PHPUnit_Framework_Assert::assertEquals('Jacek Jagiello', $command->fullName);
38+
\PHPUnit_Framework_Assert::assertTrue('j.jagiello@clearcode.cc' === $command->email);
3939
}
4040

4141
/**
@@ -59,12 +59,12 @@ public function it_returns_new_command_with_uuid_instance()
5959
*/
6060
public function it_returns_command_constructor_parameters()
6161
{
62-
$commandReflection = CommandReflection::fromClass(DummyCommand::class);
62+
$commandReflection = CommandReflection::fromClass(SignUpUser::class);
6363

6464
$commandParameters = $commandReflection->parameters();
6565

66-
\PHPUnit_Framework_Assert::assertEquals('argument1', $commandParameters[0]->name);
67-
\PHPUnit_Framework_Assert::assertEquals('argument2', $commandParameters[1]->name);
66+
\PHPUnit_Framework_Assert::assertEquals('fullName', $commandParameters[0]->name);
67+
\PHPUnit_Framework_Assert::assertEquals('email', $commandParameters[1]->name);
6868
}
6969

7070
/**

0 commit comments

Comments
 (0)