Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport ports.py modification from dbfixtures #10

Merged
merged 2 commits into from
Aug 1, 2016
Merged

backport ports.py modification from dbfixtures #10

merged 2 commits into from
Aug 1, 2016

Conversation

fizyk
Copy link
Member

@fizyk fizyk commented Jul 31, 2016

No description provided.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 83.636% when pulling 160272a on fizyk:ports into 86e691f on ClearcodeHQ:master.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 83.636% when pulling 247734a on fizyk:ports into e29100c on ClearcodeHQ:master.

@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 83.636% when pulling 247734a on fizyk:ports into e29100c on ClearcodeHQ:master.

@fizyk
Copy link
Member Author

fizyk commented Aug 1, 2016

@kblumke could you check it out?

kblumke
kblumke reviewed Aug 1, 2016
View reviewed changes
src/pytest_elasticsearch/port.py
randomly selected port (None) - any random available port
[(2000,3000)] or (2000,3000) - random available port from a given range
[{4002,4003}] or {4002,4003} - random of 4002 or 4003 ports
[(2000,3000), {4002,4003}] -random of given orange and set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo here - orange instead of range.

@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 83.636% when pulling 2bf2fb6 on fizyk:ports into e29100c on ClearcodeHQ:master.

@fizyk fizyk merged commit 8f116f0 into ClearcodeHQ:master Aug 1, 2016
@fizyk fizyk deleted the ports branch August 1, 2016 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fizyk @coveralls @kblumke