Issue #339 #340
Merged
Issue #339 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status checks for running postgres depend on pg_ctl status code, not on pg_ctl log language
fizyk
requested changes
Oct 7, 2020
There was a problem hiding this comment.
Also
- with current changes, please check if we can rid of the https://github.com/ClearcodeHQ/pytest-postgresql/blob/master/src/pytest_postgresql/executor.py#L147 usage all together.
- Either single test, or separate test env with system locales set to ie german.
src/pytest_postgresql/executor.py
Outdated
| if start_info in content: | ||
| break | ||
| status_code = subprocess.getstatusoutput( | ||
| '{pg_ctl} status -D {datadir}'.format( |
There was a problem hiding this comment.
Another question, can we simply rely on self.running method instead?
There was a problem hiding this comment.
only self.running is used now
src/pytest_postgresql/executor.py
Outdated
| @@ -176,10 +176,12 @@ def wait_for_postgres(self): | |||
| start_info = 'database system is ready to accept connections' | |||
There was a problem hiding this comment.
Also, line 173, will we need logfile check here?
|
The executor is now tested with two environment locales |
fizyk
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status checks for running postgres depend on pg_ctl status code, not on pg_ctl log language
Fixes #339.
Changes proposed.