Remove reference to psycopg2 from default param value, function body #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizyk
requested changes
Feb 19, 2021
|
other than I'm okay with everything :) |
|
Thanks for the fix, I've merged it. Have some followup commit and I'll prepare a patch release then |
|
Thank you - very much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369.
The default value for the isolation_level parameter introduced in #358 breaks pytest if psycopg2 is not installed. See #369 for detailed rationale. The proposed solution removes the reference to psycopg2 from factories.py and moves it into the method body in janitor.py. The original behavior is preserved.