Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add persistent search settings #257

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 28, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Adds persistent search settings across runs, by saving to the config file. Each process widget keeps track of it's own behaviour. The previous flags/options are now for global behaviour.

The following new behaviour is:

  • Relevant flags: --case_sensitive, --whole_word, and --regex, will override the current widget's default behaviour.
  • Relevant options: case_sensitive, whole_word, and regex, will also override the current widget's default behaviour.

As per before, if you set, say, --case_sensitiveand case_sensitive=true, the flag always overrides.

Issue

If applicable, what issue does this address?

Closes: #243

Type of change

Remove the irrelevant ones:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (if this change causes breakage or new behaviour, please state what)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
    To do in Add documentation for in-app config #248.
  • Passes Travis tests (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang merged commit 57e87d8 into master Sep 28, 2020
@ClementTsang ClementTsang deleted the persistent_search_settings branch September 28, 2020 23:50
ClementTsang added a commit that referenced this pull request Oct 12, 2022
* refactor: move to new data table implementation

* more work towards refactor

* move disk and temp over, fix longstanding bug with disk and temp if removing the last value and selected

* work towards porting over CPU

work towards porting over CPU

fix typo

partially port over cpu, fix some potentially inefficient concat_string calls

more work towards cpu widget migration

some refactoring

* sortable data

sortable data

more refactoring

some sort refactoring

more refactoringgggg

column refactoring

renaming and reorganizing

more refactoring regarding column logic

add sort arrows again

* move over sort menu

* port over process

port over process

precommit

temp

temp two, remember to squash

work

fix broken ltr calculation and CPU hiding

add back row styling

temp

fix a bunch of issues, get proc working

more fixes around click

fix frozen issues

* fix dd process killing

* revert some of the persistent config changes from #257

* fix colouring for trees

* fix missing entries in tree

* keep columns if there is no data

* add and remove tests

* Fix ellipsis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting search options should persist via config file
1 participant