bug: change as_ref() calls as needed to build in Rust beta 1.61.0 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
force-pushed
the
avoid_as_ref
branch
from
0b586f0
to
0a9af73
Compare
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
=========================================
- Coverage 7.84% 7.84% -0.01%
=========================================
Files 53 53
Lines 8269 8274 +5
=========================================
Hits 649 649
- Misses 7620 7625 +5
Continue to review full report at Codecov.
|
ClementTsang
force-pushed
the
avoid_as_ref
branch
2 times, most recently
from
f1ee90c
to
f5bd095
Compare
For context, see: - #708 - rust-lang/rust#96074 This changes the calls from `as_ref()`, which was causing type inference issues, to just `as_slice()` which works fine.
ClementTsang
force-pushed
the
avoid_as_ref
branch
from
f5bd095
to
86918a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
This changes various
as_ref()calls as needed in order for bottom to successfully build in Rust beta 1.61, as they were causing type inference issues. These calls were either removed or changed to an alternative that does build (e.g.as_slice()).Functionally, there should be no change.
Issue
If applicable, what issue does this address?
Closes: #708
Testing
If relevant, please state how this was tested. All changes must be tested to work:
Please also indicate which platforms were tested. All platforms directly affected by the change must be tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)