Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.164.3 - Tidies up some CSS with MessagingAttachment styling #747

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

chloehunter
Copy link
Contributor

@chloehunter chloehunter commented Sep 20, 2021

Jira

MOC-151

Overview

Tidies up some CSS with MessagingAttachment styling, including restoring the blue border upon focus (as opposed to default red outline).

Screenshots/GIFs

Before

Focus

Screen Shot 2021-09-20 at 12 05 33 PM
Screen Shot 2021-09-20 at 12 06 19 PM

Hover

Screen Shot 2021-09-20 at 12 16 59 PM

After

Focus

Screen Shot 2021-09-20 at 12 05 38 PM
Screen Shot 2021-09-20 at 12 06 25 PM

Hover

Screen Shot 2021-09-20 at 12 17 17 PM

Testing

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out

💯

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change?
        • If it is a beta component run npm version minor
        • If the component is not in beta run npm version major
      • New component or backward-compatible component feature change? Run npm version minor
      • Only changing documentation? All good. Skip this step.
    • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
      • Add a screenshot of the component in docs/assets/img with the format <COMPONENT URL LINK>.png
  • After merging:
    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

…ding restoring the blue border upon focus (as opposed to default red outline).
@chloehunter chloehunter marked this pull request as ready for review September 20, 2021 20:38
@pickabot pickabot bot requested a review from jonjonray September 20, 2021 20:40
@chloehunter chloehunter merged commit 9d5aea3 into master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants