rogue comma #801
Merged
rogue comma #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prime-time
reviewed
Aug 22, 2022
| @@ -157,7 +157,7 @@ function _interleaveMessagesWithDividers( | |||
| key={`alertMessage-${message.index}`} | |||
| icon={icon} | |||
| messageText={messageText} | |||
| />, | |||
| /> | |||
There was a problem hiding this comment.
It looks like this is outside of the markup actually
|
hi @Maddiebusta ! This actually didn't solve the problem. I found the comma and fixed in another PR. In the future, please test the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
A comma slipped into the html when adding A11y functionality. I just removed it. (This doesnt have a jira ticket but i added it to work i was doing on https://clever.atlassian.net/browse/PRTL-2975
Screenshots/GIFs:
Testing:
Roll Out:
package.jsonnpm version minornpm version majornpm version minorComponentsView.jsx. To do so:docs/assets/imgwith the format<COMPONENT URL LINK>.pngmake deploy-docs)