Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRTL-2025] add button role to attachment #802

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

cofauver
Copy link
Contributor

@cofauver cofauver commented Aug 24, 2022

Jira: PRTL-2025

Overview:

In order to allow screen readers to indicate that the attachment is clickable, this PR adds a button role to the descriptor text. That text is the best place for the button role because it allows the screen reader to announce the effect that clicking will have.

Screenshots/GIFs:

Before

attachment_before.mov

After

attachment_after.mov

Testing:

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change?
        • If it is a beta component run npm version minor
        • If the component is not in beta run npm version major
      • New component or backward-compatible component feature change? Run npm version minor
      • Only changing documentation? All good. Skip this step.
    • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
      • Add a screenshot of the component in docs/assets/img with the format <COMPONENT URL LINK>.png
  • After merging:
    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

Copy link
Contributor

@Maddiebusta Maddiebusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta love a button role!

@cofauver cofauver merged commit 349bb17 into master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants