noDataContent waits for pageLoading

[suelee0308]

Jira: AUTH-221

Overview:

Updating noDataContent prop to wait for data to be fully loaded before rendering the noDataContent, much like the default "NO DATA" that is returned if no noDataContent is passed.

Screenshots/GIFs:

Testing:

• Unit tests
• Manual tests:
  • Chrome
  • Safari
  • IE11

Roll Out:

• Before merging:
  • Updated docs
  • Bumped version in package.json
    • Breaking change?
      • If it is a beta component run npm version minor
      • If the component is not in beta run npm version major
    • New component or backward-compatible component feature change? Run npm version minor
    • Only changing documentation? All good. Skip this step.
  • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
    • Add a screenshot of the component in docs/assets/img with the format <COMPONENT URL LINK>.png
• After merging:
  • Deployed updated docs (make deploy-docs)
  • Posted in #eng if I made a breaking change to a beta component

[divya-amb]

Can you please add some screenshots? And also test it out in Safari?

[suelee0308]

(Both screenshots from Safari)
Preview step:

Works the same on the MFA main page:

[divya-amb]

(Both screenshots from Safari) Preview step:

Works the same on the MFA main page:

What is the "Before" like?

[suelee0308]

It just says "NO DATA"

[divya-amb]

Looking at how the code was before your change, I would expect that in the "Before" case, when you pass in noDataContent, the button would show up while the table content was loading as well as after the table content finished loading. Am I missing something here?

[suelee0308]

Ah, yes. This might give some context https://clever.slack.com/archives/C0ERS5ABB/p1673560803891299

[divya-amb]

Thank you for sharing the slack link. So the "Before" is this image then?

Before you made changes in this component, would the button keep appearing after the "Loading" overlay vanished?

[suelee0308]

It would keep appearing if there was no data. But it would appear regardless while the "Loading" appeared.

[divya-amb]

LGTM