Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 2.216.0 version with peerDependencies properly defined #827

Merged
merged 4 commits into from
May 4, 2023

Conversation

ulziibay
Copy link
Contributor

@ulziibay ulziibay commented Mar 29, 2023

Jira: SECNG-1644

Overview:

For npm7+ to properly install this package, the peerDependency list must be properly defined as explained in https://github.com/npm/rfcs/blob/main/implemented/0025-install-peer-deps.md. For example, this was needed to be able install this package using npm9 within SD2 in https://github.com/Clever/sd2/pull/6203.

Additionally, moved the @types packages to dependency from devDependency for correctness.

Screenshots/GIFs:

Testing:

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change?
        • If it is a beta component run npm version minor
        • If the component is not in beta run npm version major
      • New component or backward-compatible component feature change? Run npm version minor
      • Only changing documentation? All good. Skip this step.
    • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
      • Add a screenshot of the component in docs/assets/img with the format <COMPONENT URL LINK>.png
  • After merging:
    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

@ulziibay ulziibay changed the title Publish 3.0.0 version with peerDependencies properly defined Publish 2.3.0 version with peerDependencies properly defined May 2, 2023
@ulziibay ulziibay changed the title Publish 2.3.0 version with peerDependencies properly defined Publish 2.216.0 version with peerDependencies properly defined May 2, 2023
@ulziibay ulziibay requested review from dxu429 and brollin May 3, 2023 15:21
package.json Show resolved Hide resolved
@ulziibay ulziibay merged commit 8086f5b into master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants