Add basepath option #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiangriset
force-pushed
the
add-basepath-option
branch
from
d3e3cb3
to
271b2d3
Compare
christiangriset
force-pushed
the
add-basepath-option
branch
from
271b2d3
to
9536079
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.0.0, when generating a temp file the prefix is simply
/. Here we add flexibility to prepend with a provided base_path. This is crucial for certain types of repo changes. For example, if your changes involve ago get, you'll get an error if you're not operating within your gopath. With this new option you can add something like the following to yourgitbot.ymlThis was motivated by work porting repos to go1.5 vendoring.
Tested changes by running with local builds.
@rgarcia