Fix express sample so post_assert callback doesn't throw an error #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A big thank you, your fix saved me! |
mcab
added a commit
that referenced
this pull request
Oct 15, 2022
- Closes #183. Addresses some issues with using the example in strict mode. - Closes #231. Replaces Buffer() with Buffer.from(). - Closes #233. Uses underscore in a manner more compatible with TypeScript. - Closes #238. Replaces body-parser with urlencoded() for express >=4. - Adds maintenance notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conversation in #115 I found that the Express sample in the README also has the same issue. Both
name_idandsession_indexare undeclared and will throw in error in strict environments. Pretty straightforward fix that'll make the sample code a bit more portable. :)