add optional callback and emit 'done' when finish posting to sentry #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiancheung
force-pushed
the
add-cb-to-error-method
branch
from
39a620a
to
db34be1
Compare
|
Is it a problem that we are sending back multiple events (done and then error) in some cases? I don't think so because they need different handlers, but just checking. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no good way to know if
sentry.errororsentry.messagehas actually finish the POST request to sentry.This PR adds an optional callback and makes it emit 'done' to know when it has finish POSTing to sentry.