Finish removing state from points_left

src/avatar.cpp

@@ -1534,29 +1534,23 @@ std::unique_ptr<talker> get_talker_for( avatar *me )
     return std::make_unique<talker_avatar>( me );
 }
 
-int avatar::randomize_hobbies()
+void avatar::randomize_hobbies()
 {
     hobbies.clear();
     std::vector<profession_id> choices = profession::get_all_hobbies();
 
     int random = rng( 0, 5 );
-    int points = 0;
 
     if( random >= 1 ) {
         const profession_id hobby = random_entry_removed( choices );
-        points += hobby->point_cost();
         hobbies.insert( &*hobby );
     }
     if( random >= 3 ) {
         const profession_id hobby = random_entry_removed( choices );
-        points += hobby->point_cost();
         hobbies.insert( &*hobby );
     }
     if( random >= 5 ) {
         const profession_id hobby = random_entry_removed( choices );
-        points += hobby->point_cost();
         hobbies.insert( &*hobby );
     }
-
-    return points;
 }

src/avatar.h

@@ -89,7 +89,7 @@ class avatar : public player
         // newcharacter.cpp
         bool create( character_type type, const std::string &tempname = "" );
         void add_profession_items();
-        void randomize( bool random_scenario, points_left &points, bool play_now = false );
+        void randomize( bool random_scenario, bool play_now = false );
         bool load_template( const std::string &template_name, points_left &points );
         void save_template( const std::string &name, const points_left &points );
         void character_to_template( const std::string &name );
@@ -295,7 +295,7 @@ class avatar : public player
         void log_activity_level( float level ) override;
         std::string total_daily_calories_string() const;
         //set 0-3 random hobbies, with 1 and 2 being twice as likely as 0 and 3
-        int randomize_hobbies();
+        void randomize_hobbies();
 
         int movecounter = 0;
 

src/character.h

@@ -1985,7 +1985,6 @@ class Character : public Creature, public visitable
          * And if you do already have them, refunds the points for the trait
          */
         void add_traits();
-        void add_traits( points_left &points );
         /** Returns true if the player has crossed a mutation threshold
          *  Player can only cross one mutation threshold.
          */