Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14559 breaks save game compatibility #15102

Closed
macrosblackd opened this issue Jan 30, 2016 · 7 comments
Closed

#14559 breaks save game compatibility #15102

macrosblackd opened this issue Jan 30, 2016 · 7 comments

Comments

@macrosblackd
Copy link
Contributor

By virtue of removing an item id from the JSON without any logic to handle the conversion, older save games are going to be broken. This was just brought to my attention due to a forum post regarding this PR.
#14559

@TheRafters
Copy link
Contributor

#14559 also breaks UPS as details in another forum post http://smf.cataclysmdda.com/index.php?topic=12053.0
Calling all @Core0verload 's, please fix. Discussion on the UPS affects in this PR never happened, it got overwhelmed by talking about battery weights.

@BevapDin
Copy link
Contributor

By virtue of removing an item id from the JSON without any logic to handle the conversion, older save games are going to be broken

What id had been removed? The linked PR adds a few items and moves some definitions around, but I can't see entries that have been removed.

@macrosblackd
Copy link
Contributor Author

Guess you're right - I coulda swore I saw a missing ID - that's what I get for looking at anything with 4 hours of sleep.

@Core0verload
Copy link

I did NOT removed any IDs. As for "Broken UPS charging" and "some tools don't work without UPS" - there is #14976 that's I'm now trying to fix. Sadly, it's easier to talk about "balance" than to test my changes with various tools and point out the issues.

This issue can be closed as a dupe of #14976.

@illi-kun
Copy link
Contributor

Sadly, it's easier to talk about "balance" than to test my changes with various tools and point out the issues.

That's mostly your responsibility to test changes you're proposing to merge, no need to blame anyone else about that.

@macrosblackd
Copy link
Contributor Author

Since I was mistaken about the save breakage, closing - I need more sleep.

@Core0verload
Copy link

That's mostly your responsibility to test changes you're proposing to merge, no need to blame anyone else about that.

I'm just still a bit mad about all that pointless balance talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants