-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#14559 breaks save game compatibility #15102
Comments
#14559 also breaks UPS as details in another forum post http://smf.cataclysmdda.com/index.php?topic=12053.0 |
What id had been removed? The linked PR adds a few items and moves some definitions around, but I can't see entries that have been removed. |
Guess you're right - I coulda swore I saw a missing ID - that's what I get for looking at anything with 4 hours of sleep. |
I did NOT removed any IDs. As for "Broken UPS charging" and "some tools don't work without UPS" - there is #14976 that's I'm now trying to fix. Sadly, it's easier to talk about "balance" than to test my changes with various tools and point out the issues. This issue can be closed as a dupe of #14976. |
That's mostly your responsibility to test changes you're proposing to merge, no need to blame anyone else about that. |
Since I was mistaken about the save breakage, closing - I need more sleep. |
I'm just still a bit mad about all that pointless balance talk. |
By virtue of removing an item id from the JSON without any logic to handle the conversion, older save games are going to be broken. This was just brought to my attention due to a forum post regarding this PR.
#14559
The text was updated successfully, but these errors were encountered: