Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafted light amp goggles with atomic battery mod can not be (r)eloaded with plutonium cells #20878

Closed
Vidiveni opened this issue Apr 21, 2017 · 10 comments · Fixed by #31372
Closed
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@Vidiveni
Copy link

Vidiveni commented Apr 21, 2017

Trying will just print the "Out of battery!" message. The other devices I've tried work fine with the atomic mod (Heavy duty flashlight, Noise emitter, Makeshift welder).

Windows x64 tiles build 6403.

@AMurkin
Copy link
Contributor

AMurkin commented Apr 21, 2017

Are you sure that was atomic battery mod? Maybe battery compartment mod?

@Coolthulhu
Copy link
Contributor

Coolthulhu commented Apr 21, 2017

Could be related to it being an armor. Does it reproduce with infrared goggles?

@AMurkin
Copy link
Contributor

AMurkin commented Apr 21, 2017

Yeah, you mean infrared. Both is not an armor. Can't reproduce in 0.C-22065.

@Vidiveni
Copy link
Author

Vidiveni commented Apr 21, 2017

No, I mean the atomic mod on the amp goggles. Not the battery compartment mod. I could try to upload a save.

Edit: Yeah same problem exists with atomic mod on infrared goggles. They can't be reloaded even with plutonium cells in inventory.

@Vidiveni
Copy link
Author

Vidiveni commented Apr 22, 2017

I can't reproduce either if using debug in a new game, but on my save they still don't work:

CDDA Broken atomic mod on goggles save 170422.zip

This is the folder with the name of the bugged save from inside the \save folder. Build 6404.

Edit: The problem appears to only exist with player crafted goggles. How to reproduce:

  1. Make new world/game
  2. Debug all skills to 10.
  3. Unlock all recipes.
  4. Wish for 1x screwdriver, 1x welding goggles, 1x power converter, 3x amplifier circuits, 5x scrap metal.
  5. Craft pair of light amp goggles.
  6. Wish for atomic battery mod.
  7. (a)pply atomic battery mod to the pair of light amp goggles.
  8. Wish for 5x plutonium cells.
  9. Try to (r)eload the goggles.

@Vidiveni Vidiveni changed the title Light amp goggles with atomic battery mod can not be (r)eloaded with plutonium cells Crafted light amp goggles with atomic battery mod can not be (r)eloaded with plutonium cells Apr 22, 2017
@Leland Leland added <Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels May 1, 2017
@Ishindri
Copy link
Contributor

Ishindri commented May 3, 2017

Can confirm, was able to reproduce on build 6416, Win 7 x64 w/tiles.

@AMurkin
Copy link
Contributor

AMurkin commented May 3, 2017

Can confirm too. Screenshot and part of savefile:

o ++ - is wished, z || - is crafted
image

bottom - is wished, top - is crafted

{
  "typeid": "goggles_nv",
  "bday": 1164841,
  "invlet": 122,
  "contents": [
    {
      "typeid": "battery_atomic",
      "bday": 1164874,
      "invlet": 73
    }
  ],
  "components": [
    {
      "typeid": "goggles_welding",
      "invlet": 65
    },
    {
      "typeid": "power_supply",
      "bday": 1164422,
      "invlet": 122
    },
    {
      "typeid": "amplifier",
      "invlet": 65
    },
    {
      "typeid": "amplifier",
      "invlet": 65
    },
    {
      "typeid": "amplifier",
      "bday": 415780,
      "invlet": 72
    },
    {
      "typeid": "scrap",
      "charges": 5,
      "bday": 633760,
      "invlet": 75
    }
  ],
  "curammo": "battery"
},
{
  "typeid": "goggles_nv",
  "charges": 5000,
  "bday": 1163440,
  "invlet": 111,
  "damage": -1.000000,
  "contents": [
    {
      "typeid": "battery_atomic",
      "bday": 1164874,
      "invlet": 73
    }
  ],
  "curammo": "plut_cell"
}

@Zireael07
Copy link
Contributor

Crafted version doesn't have curammo set. Wonder why? @Coolthulhu

@Night-Pryanik Night-Pryanik added Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items / Item Actions / Item Qualities Items and how they work and interact labels Apr 6, 2019
@Mooses2k
Copy link
Contributor

Mooses2k commented May 27, 2019

In the spirit of the 'no making laser sights', and the spirit of balance, and lastly the spirit of having to scavenge rather than craft high-end gear, let's remove crafting on IR and NV googles.

@kevingranade
Copy link
Member

Yes, this is not a reasonable thing to craft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants