Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting in city location with City Size at 0 freezes game #21667

Closed
Leland opened this issue Aug 19, 2017 · 3 comments
Closed

Starting in city location with City Size at 0 freezes game #21667

Leland opened this issue Aug 19, 2017 · 3 comments
Labels
<Bug> This needs to be fixed <Crash / Freeze> Fatal bug that results in hangs or crashes. Spawn Creatures, items, vehicles, locations appearing on map
Milestone

Comments

@Leland
Copy link
Contributor

Leland commented Aug 19, 2017

Steps to reproduce the behavior

  1. In world creation, set "Size of cities" to 0.
    The help text notes that this disables cities entirely.
  2. Create a character in a scenario that only has city-based starting locations. An example is the "missed" scenario.
  3. Finish character creation. The game will display a dialog, "Please wait as we build your world," as the game steadily takes up more memory.

I have a hunch that what's going on behind the scenes is, with #21212, the game is generating more and more overmaps to find a suitable location for a starting location special. That will never happen, however, as no spawn locations have suitable areas for placement.

@Leland Leland added <Bug> This needs to be fixed Spawn Creatures, items, vehicles, locations appearing on map labels Aug 19, 2017
@Leland Leland added the <Crash / Freeze> Fatal bug that results in hangs or crashes. label Aug 19, 2017
@kevingranade kevingranade added this to the 0.D milestone Sep 8, 2017
@laeaton2001
Copy link
Contributor

I could add a flag to the scenarios JSON to mark scenarios as a city start & then add a check in newcharacter.cpp to filter out city starts when the active world options have city size set to 0.
My only concern is this will hide scenarios from the player with no feedback as to why.

@Night-Pryanik
Copy link
Contributor

And add a remark to the options description, like "This disables cities and all the scenarios with city start".

@Coolthulhu
Copy link
Contributor

Color the scenarios dark gray, sort them to the last on the list, then in their description prepend "This scenario is not available in this world due to city size settings".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed <Crash / Freeze> Fatal bug that results in hangs or crashes. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

No branches or pull requests

5 participants