Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swimming in deep water does not ruin matchbooks #35878

Closed
ghost opened this issue Dec 5, 2019 · 2 comments · Fixed by #55751
Closed

Swimming in deep water does not ruin matchbooks #35878

ghost opened this issue Dec 5, 2019 · 2 comments · Fixed by #55751
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@ghost
Copy link

ghost commented Dec 5, 2019

Describe the bug

Swimming in deep water without specialized watertight containers would realistically ruin matches very quickly, and certainly at least render them inoperable until dried.

Steps To Reproduce

Have matchbook containing matches in inventory, swim in deep water

Expected behavior

Matchbook (x) should have condition degraded or destroyed on contact with deep water

A clear and concise description of what you expected to happen.
Ideally also describe why you expect it to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Versions and configuration

  • OS: [e.g. iOS 8 or Windows 10 or Ubuntu 18.04]
  • Game Version: [from the main menu, e.g. 0.C-29938-g90f5268437]
  • Graphics version: [Tiles or Terminal]
  • Mods loaded: [e.g.dda, boats, hacktheplanet, StatsThroughSkills]

Additional context

Add any other context about the problem here.

@Night-Pryanik Night-Pryanik added Items / Item Actions / Item Qualities Items and how they work and interact <Bug> This needs to be fixed labels Dec 5, 2019
@Sumguy62
Copy link
Contributor

Sumguy62 commented Dec 6, 2019

We don't have containers yet, so having waterproof containers to mitigate the "issue" of items being damaged by getting wet is impossible at this time. I'd hold off on "fixing" this until there's a way to protect items from water damage.

@wapcaplet wapcaplet added the Good First Issue This is a good first issue for a new contributor label Dec 16, 2021
@wapcaplet
Copy link
Contributor

Should be easy to do now since #47018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants