Auditing guns & magazine volumes

[ghost]

Is your feature request related to a problem? Please describe.
Guns and magazines are mostly still defined volumetrically by 250ml * n for both their own volume and the magwell's, in the case of the former. In general:
-Pistols & magazines are too big
Example:
Glock 17(which is the full-size version, the 19 is both more common and less spacy but defined also as 500ml) ingame is defined as 500ml

Using their official measurement for overall length as scale & multiplying by width gets a volume of 435ml.
-Longguns are too small

Describe the solution you'd like
Running all guns & magazines through ImageJ(#33711, #34666, and #36838 used it) to get their volumes as gun-shaped prisms, then updating spare ammo containers & holsters on some basis of them.

Progress:

• 12 mm
• 20x66 mm
• .22 LR
• .223 Remington
• .270 Winchester
• .300 Winchester Magnum
• .30-06 Springfield
• .300 AAC Blackout
• .308 Winchester
• .32 ACP
• .38 Special & .357 Magnum
• .380 ACP
• .38 Super
• .40 S&W
• 40x46 mm
• 40x53 mm
• .410 shot
• .44 Magnum
• .44 Paper
• .45 ACP
• .454 Casull
• .45-70 Government
• .45 Long Colt
• HK 4.6x30mm
• .460 Rowland
• .50 BMG
• .500 S&W Magnum
• 5.45x39
• 5.7 x 28 mm
• 66 mm
• .700 Nitro Express
• 7.62x39 mm
• 7.62x54mmR
• 7.62x25 mm
• 84x246mm
• 9mm Parabellum
• 9mm Makarov
• Anti-tank Guided Missiles
• Blunderbuss
• Flintlock
• 12 gauge
• Flaregun

[GGgatherer]

To really make this work you'd need to add "longest dimension" property to items and containers (in addition to volume). Then some rifle may still take only 2L by volume but you wouldn't be able to store it even in a 12L(or whatever) backpack because it's longer that the backpack.

[ghost]

I've actually already talked with KorG about that, longest dimension will be added as a property for use with the holster refactor.

[KorGgenT]

yeah it'll happen during the nested containers project and holster refactor at some point

[ghost]

Posting a tutorial so people other than tenmillimaster and I can help:

0. Download the free program ImageJ.

Using OA-93 pistol as example(17" overall length):

1. Get image of gun, with a known length and width.
2. Make the gun solid black on white background by using this option:
   
3. Fill gaps in gun with Fill Holes.
   
4. Click the gun with the wand tool active.
   
5. Crop with ctrl+shift+x.
6. Set the scale's known pixels(ex. 1118 pixels from pistol math) to its known length of 17in.
   
   
7. Analyze particles to get surface area of the gun.
   
   
8. Multiply by gun's width, and convert to ml(if necessary).
9. For after Item length #40186 is merged, set "longest_side" to the Feret diameter. You can set this in Set Measurements
   

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[ghost]

I'll be able to put in a lot more work next week, once spring break starts. Begone stalebot!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.